ReviewOS

home-lang/home

Account adjacent conditional Valkey reliability corpus

#317
Closed chris opened this 10 days ago ·
10 days ago

Bun compatibility slice

Account the adjacent Docker-conditional Valkey reliability files beginning at exhaustive position 4071:

  • error-handling.test.ts;
  • protocol-handling.test.ts;
  • recovery.test.ts.

Required Home behavior

  • parse the actual complete sources rather than rejecting shared test-utils imports;
  • extend the common Home Valkey fixture surface with deterministic testKey, type assertion, defaults, and availability helpers;
  • preserve one suite-level todo per Docker-guarded source when the external fixture is unavailable;
  • reuse #315's structured and redacted ValkeyClientError components;
  • pin the exact contracts in the permanent mini-suite and keep zero failures/unsupported cases.

Tracked from #66, #315, and #316.

10 days ago

Implemented and pushed in 1e808c3b8.

The actual Valkey error-handling, protocol-handling, and recovery sources now lower fully through the common fixture module. That module now exposes deterministic testKey, type assertion, defaults, and availability helpers while continuing to report the unavailable Docker-backed fixture honestly.

Each guarded source preserves the runner's exact one suite-level todo and shares #315's permanent ValkeyClientError operation/cause/redaction contract.

Verification:

  • positions 4071–4073: 3 files, 3 todos, 0 failed, 0 unsupported;
  • permanent third-party mini-suite and 46 error diagnostics: passed;
  • formatting and diff checks: passed.

Sign in to comment on this issue.