ReviewOS

home-lang/home

Account conditional Valkey complex-operations corpus

#315
Closed chris opened this 9 days ago ·
9 days ago

Bun compatibility slice

Port/account js/valkey/integration/complex-operations.test.ts at exhaustive corpus position 4069.

Upstream execution contract

The ten nested transaction, complex-key, cache, leaderboard, and distributed-lock cases are guarded by describe.skipIf(!isEnabled). Bun's shared Valkey utilities set isEnabled only when a working Docker daemon and Redis fixture are available. The runner records that skipped container as one suite-level todo.

Required Home behavior

  • lower and parse the actual source, including all ten nested test definitions;
  • expose a deterministic Valkey test-utils module that reports the unavailable external fixture instead of rejecting the file as unsupported syntax;
  • preserve the exact one suite-level todo when the Docker-backed fixture is unavailable;
  • add a structured Valkey connection error with causal operation/endpoint stacks and credential/path/query redaction;
  • keep the exhaustive and permanent corpus gates at zero failures and zero unsupported cases.

Tracked from #66.

9 days ago

Implemented and pushed in 74934867b.

The actual complex-operations source now lowers successfully and resolves its shared test utilities through Home instead of being rejected as unsupported module syntax. With no Docker-backed Valkey fixture available, its describe.skipIf container is preserved as the runner's exact one suite-level todo; all ten nested operation definitions remain parsed behind that condition.

The fixture module also provides ValkeyClientError with ERR_VALKEY_CLIENT, valkey.<phase> operation frames, endpoint metadata, retained causes, and redaction of Redis credentials, database paths, and query secrets.

Verification:

  • focused position 4069: 0 passed, 1 suite todo, 0 failed, 0 unsupported;
  • adjacent positions 4068–4069: 1 passed, 1 todo, 0 failed, 0 unsupported;
  • permanent third-party mini-suite: passed, including 46 structured-error diagnostics;
  • formatting and diff checks: passed.

Sign in to comment on this issue.