ReviewOS

home-lang/home

Account conditional Valkey connection-failure corpus

#316
Closed chris opened this 11 days ago ·
11 days ago

Bun compatibility slice

Port/account js/valkey/reliability/connection-failures.test.ts at exhaustive corpus position 4070.

The actual reliability source contains connection failure, timeout, reconnect, callback, manual-close, and rapid-failure cases behind the same Docker-backed describe.skipIf(!isEnabled) Valkey fixture guard.

Required Home behavior

  • lower the actual imports and parse the complete source;
  • expose the shared default URL/options/delay surface through Home's Valkey test-utils module;
  • preserve the exact suite-level todo when the external fixture is unavailable;
  • reuse the structured ValkeyClientError causal/endpoint stack contract from #315;
  • keep focused and permanent gates at zero failures and zero unsupported cases.

Tracked from #66 and #315.

11 days ago

Implemented and pushed in f62a23814.

The actual connection-failures source now lowers fully. Its shared DEFAULT_REDIS_URL, default options, delay helper, and fixture availability flag resolve through the common Home Valkey test-utils module from #315. Without the Docker-backed fixture, the complete reliability container is preserved as exactly one suite-level todo rather than unsupported syntax.

The slice reuses the permanent ValkeyClientError contract for causal valkey.<phase> stacks and redacted endpoint context.

Verification:

  • focused position 4070: 0 passed, 1 suite todo, 0 failed, 0 unsupported;
  • adjacent positions 4069–4070: 0 passed, 2 todos, 0 failed, 0 unsupported;
  • permanent third-party mini-suite and 46 error diagnostics: passed;
  • formatting and diff checks: passed.

Sign in to comment on this issue.