ReviewOS

also looking at this

stacks/drone

feat: add bounded VTOL wind braking

#88
Merged chris wants to merge codex/owned-vtol-wind into main
13 files +447 -25
tests/unit/vtol-recovery.test.tsmodified+19-6
Changes to tests/unit/vtol-recovery.test.ts
@@ -176,7 +176,12 @@ test('an early resume and repeated recovery cannot skip observed hover or extend
176176 expect(new Set(requests.map(request => request.eventId)).size).toBe(1)
177177 expect(requests.every(request => request.issuedAtMs === 13000 && request.expiresAtMs === 58000)).toBe(true)
178178 expect(report.path.find(row => row.atMs === 13200)!.mission.state).toBe('running')
179 expect(report.path.find(row => row.atMs === 20000)!.mission.state).toBe('paused')
179 const observedHover = report.trace.rows.find(row => row.observation.transition?.taskId === 'recover-hover' && row.observation.transition.outcome === 'confirmed')
180 expect(observedHover).toBeDefined()
181 expect(observedHover!.observation.nowMs).toBeGreaterThan(13400)
182 expect(observedHover!.observation.nowMs).toBeLessThan(40000)
183 expect(observedHover!.result.state).toBe('paused')
184 expect(report.path.filter(row => row.atMs >= 13200 && row.atMs < observedHover!.observation.nowMs).every(row => row.mission.state === 'running' && row.mission.taskId === 'recover-hover')).toBe(true)
180185 expect(report.path.find(row => row.atMs === 39980)!.mission.state).toBe('paused')
181186 expect(report.mission.reason).toBe('vtol-recovery-landed')
182187 expect(replayVehicleMission(report.trace).snapshot()).toEqual(report.mission)
@@ -193,7 +198,11 @@ for (const abortAtMs of [15000, 20000]) test(`an abort at ${abortAtMs} upgrades
193198 expect(replayVehicleMission(report.trace).snapshot()).toEqual(report.mission)
194199})
195200
196for (const [sourceTask, atMs] of [['initial-hover', 620], ['front', 11320], ['back', 27400]] as const) test(`a ${sourceTask} abort before its first command dispatch does not invent a cancelled event`, () => {
201for (const sourceTask of ['initial-hover', 'front', 'back'] as const) test(`a ${sourceTask} abort before its first command dispatch does not invent a cancelled event`, () => {
202 const baseline = runVehicleSimulation(declaredRecovery(sourceTask), { seconds: 160 })
203 const firstRequest = baseline.path.find(row => row.mission.transition?.taskId === sourceTask)
204 expect(firstRequest).toBeDefined()
205 const atMs = firstRequest!.atMs
197206 const report = runVehicleSimulation(declaredRecovery(sourceTask), { seconds: 180, missionActions: [{ atMs, action: 'abort' }] })
198207 expect(report.mission.reason).toBe('vtol-abort-landed')
199208 expect(report.mission.recovery?.failedEventId).toBeNull()
@@ -235,7 +244,7 @@ test('a declared front-transition failure route cancels failed wing support, obs
235244 expect(replayVehicleMission(report.trace).snapshot()).toEqual(report.mission)
236245})
237246
238for (const landingTimeoutMs of [25000, 35000]) test(`back-transition recovery retains the declared ${landingTimeoutMs} ms approach and landing budget`, () => {
247for (const [landingTimeoutMs, worstCaseMs, requiredWh] of [[20000, 141520, 47.17333333333333], [25000, 146520, 48.84], [35000, 156520, 52.17333333333333]] as const) test(`back-transition recovery retains the declared ${landingTimeoutMs} ms approach and landing budget`, () => {
239248 const profile = declaredRecovery('back'), back = profile.mission.tasks.find(task => task.id === 'back')!
240249 if (back.kind !== 'vtol-mode') throw new Error('Expected a VTOL mode task')
241250 back.timeoutMs = 15000
@@ -244,18 +253,22 @@ for (const landingTimeoutMs of [25000, 35000]) test(`back-transition recovery re
244253 hover.timeoutMs = 45000; land.timeoutMs = landingTimeoutMs
245254 const report = runVehicleSimulation(profile, { seconds: 160 })
246255 console.log('VTOL_BACK_TIMEOUT_RECOVERY', JSON.stringify({ landingTimeoutMs, status: report.status, fault: report.fault, mission: report.mission, budget: report.budget, finalPositionM: report.finalTruthPositionM, transitions: report.transitions }))
247 if (landingTimeoutMs === 25000) {
256 expect(report.budget.worstCaseMs).toBe(worstCaseMs)
257 expect(report.budget.requiredWh).toBeCloseTo(requiredWh, 8)
258 const landingStart = report.transitions.find(row => row.taskId === 'recover-land' && row.state === 'running')!.atMs
259 if (landingTimeoutMs === 20000) {
248260 expect(report.status).toBe('blocked')
249261 expect(report.mission.reason).toBe('task-timeout')
250262 expect(report.path.at(-1)!.measurement!.values.onSurface).toBe(false)
251263 expect(report.finalTruthPositionM[2]).toBeLessThan(-1)
252264 expect(report.board.actuators).toEqual([0, 0, 0, 0, 0, 0, 0, 0])
265 expect(report.board.expiresAtMs).toBeNull()
266 expect(report.path.at(-1)!.atMs - landingStart).toBe(landingTimeoutMs)
253267 expect(replayVehicleMission(report.trace).snapshot()).toEqual(report.mission)
254268 return
255269 }
256270 expect(report.status).toBe('completed')
257 expect(report.budget.worstCaseMs).toBe(156520)
258 expect(report.budget.requiredWh).toBeCloseTo(52.17333333333333, 8)
271 expect(report.path.at(-1)!.atMs - landingStart).toBeLessThan(landingTimeoutMs)
259272 expect(report.mission.reason).toBe('vtol-recovery-landed')
260273 expect(report.mission.recovery).toMatchObject({ failedTaskId: 'back', hoverTaskId: 'recover-hover', cause: 'timeout' })
261274 const original = report.path.find(row => row.mission.taskId === 'back' && row.mission.transition)!.mission.transition!