ReviewOS

also looking at this

stacks/drone

feat: model VTOL electrical consumption and battery authority

#81
Merged chris wants to merge codex/owned-vtol-electrical-energy into main
15 files +605 -28
8 days ago

Summary

Add an explicit electrical option to the owned VTOL hover and transition library profiles and the native vtol:hover --electrical command. Legacy defaults preserve their complete reports.

lagged independent rotors + pusher + surfaces + auxiliaries
  fictional electrical load and battery series loss
  delayed, capture-qualified battery readings
  age-bounded remaining energy
  existing mission reserve and authority supervision

Each session owns its chemical-energy state and latched supply cutoff. A derived 1061 W simultaneous source ceiling must fit the declared planning ceiling before allocation. Invalid, reset, missing or supply-cutoff readings cannot invent usable charge. Host-loss reports retain their final observation while the independent modeled plant and output board continue. Docs explain the fictional law and open qualification gates.

Evidence

  • Actual red cases exposed missing plant accounting, preflight/measurement flow, cutoff authority withdrawal and the native flag. Public tests now cover independent load/integration, simultaneous peak, atomic rejection, delayed/malformed readings, all route phases, pause/recovery/abort/landing, endurance/reserve, source/manual/host loss and session isolation.
  • Native Buddy/Pickier, application/runtime types, 90-page docs, roadmap/parity and official standalone CLI build pass. Broad focused result: 281 passes, zero failures, 11,959 assertions across 20 files. An additional transition-timeout case then passed with all 29 energy cases / 214 assertions; functional inputs were unchanged.
  • Seven electrical scenarios from the copied standalone binary outside the checkout exactly match native Buddy JSON. Complete legacy hover and transition reports are byte-identical to the actual clean parent. Insufficient duration and unknown scenario retain exit 1.
  • Independent Spec and Standards reviews are clean after fixing a real CI step-directory ownership regression. The parsed-YAML regression went red first; all four CLI tests now pass with 44 assertions, and all four standalone VTOL workflow steps explicitly run in runner.temp. Existing jobs, commands and deadlines are preserved.
  • Exact full Linux qualification passed all five jobs: 1,713 passes, 41 skips, zero failures, 499,371 assertions across 209 files. All four standalone VTOL reports match their expected completion/host-loss outcomes and neutral output; both electrical cases retain qualified capture-age accounting. The sole original log archive was verified without refetch. No full macOS suite pass is claimed. Historical failures remain retained.
  • Published 9fd04256b7ca33b6e40310acc01eaf68f5b9e969 to main with a normal fast-forward as Chris, without coauthors. The automatic main publication run is a separate qualification run.

Merge Danger

Door: Two-way. Optional simulation feature, no schema or physical endpoint change.

Blast Radius: Simulation. The electrical coefficients and 20 to 24 V curve are fictional, with no measured cell/motor, thermal, voltage-dependent thrust, advance-ratio or locked-rotor-current identification. Whole-graph reserve/endurance and independent authority remain controlling. Full-transition native CLI/common workspace, wind/envelope campaigns, fresh-process recovery and board/HIL/physical evidence remain open in #12. This milestone does not complete VTOL or autopilot parity.

15 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.