ReviewOS

also looking at this

meemalabs/laravel-text-to-speech

Apply fixes from StyleCI

#8
Merged luigel wants to merge analysis-YjWG3v into master
3 files +14 -16
src/Converters/PollyConverter.phpmodified+0-2
Changes to src/Converters/PollyConverter.php
@@ -29,8 +29,6 @@ class PollyConverter implements Converter
2929 $this->client = $client;
3030 }
3131
32
33
3432 /**
3533 * Get the Polly Client.
3634 *
src/TextToSpeechManager.phpmodified+2-1
Changes to src/TextToSpeechManager.php
@@ -43,7 +43,7 @@ class TextToSpeechManager extends Manager
4343 }
4444
4545 /**
46 * Sets the polly client
46 * Sets the polly client.
4747 *
4848 * @param array $config
4949 * @param Credentials $credentials
formatting only · 7 hidden lines
Changes to src/TextToSpeechManager.php
@@ -57,6 +57,7 @@ class TextToSpeechManager extends Manager formatting only
5757 'credentials' => $credentials,
5858 ]);
5959 }
60
6061 /**
6162 * Get credentials of AWS.
6263 *
tests/PollyConverterTest.phpmodified+12-13
Changes to tests/PollyConverterTest.php
@@ -8,14 +8,13 @@ use Illuminate\Support\Facades\Storage;
88
99class PollyConverterTest extends TextToSpeechTestCase
1010{
11
1211 /**
1312 * @var PollyClient
1413 */
1514 protected $client;
1615
1716 /**
18 * Setup client and results
17 * Setup client and results.
1918 *
2019 * @return void
2120 */
formatting only · 28 hidden lines
Changes to tests/PollyConverterTest.php
@@ -85,17 +84,17 @@ class PollyConverterTest extends TextToSpeechTestCase formatting only
8584 $this->assertTrue(strpos($path, '.mp3') !== false);
8685 }
8786
88 /** @test */
89 public function it_should_specify_path_source_and_be_able_to_retrieve_text()
90 {
91 Storage::fake('s3');
92
93 $converter = new PollyConverter($this->client);
94
95 $path = $converter->disk('local')
87 /** @test */
88 public function it_should_specify_path_source_and_be_able_to_retrieve_text()
89 {
90 Storage::fake('s3');
91
92 $converter = new PollyConverter($this->client);
93
94 $path = $converter->disk('local')
9695 ->source('path')
9796 ->convert('tests/TestFiles/test.txt');
98
99 Storage::assertExists($path);
100 }
97
98 Storage::assertExists($path);
99 }
101100}