also looking at this
meemalabs/laravel-text-to-speech
Apply fixes from StyleCI
#8
3 files
+14
-16
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -43,7 +43,7 @@ class TextToSpeechManager extends Manager | ||
| 43 | 43 | } |
| 44 | 44 | |
| 45 | 45 | /** |
| 46 | * Sets the polly client | |
| 46 | * Sets the polly client. | |
| 47 | 47 | * |
| 48 | 48 | * @param array $config |
| 49 | 49 | * @param Credentials $credentials |
| @@ -57,6 +57,7 @@ class TextToSpeechManager extends Manager formatting only | ||
| 57 | 57 | 'credentials' => $credentials, |
| 58 | 58 | ]); |
| 59 | 59 | } |
| 60 | ||
| 60 | 61 | /** |
| 61 | 62 | * Get credentials of AWS. |
| 62 | 63 | * |
| @@ -8,14 +8,13 @@ use Illuminate\Support\Facades\Storage; | ||
| 8 | 8 | |
| 9 | 9 | class PollyConverterTest extends TextToSpeechTestCase |
| 10 | 10 | { |
| 11 | ||
| 12 | 11 | /** |
| 13 | 12 | * @var PollyClient |
| 14 | 13 | */ |
| 15 | 14 | protected $client; |
| 16 | 15 | |
| 17 | 16 | /** |
| 18 | * Setup client and results | |
| 17 | * Setup client and results. | |
| 19 | 18 | * |
| 20 | 19 | * @return void |
| 21 | 20 | */ |
| @@ -85,17 +84,17 @@ class PollyConverterTest extends TextToSpeechTestCase formatting only | ||
| 85 | 84 | $this->assertTrue(strpos($path, '.mp3') !== false); |
| 86 | 85 | } |
| 87 | 86 | |
| 88 | /** @test */ | |
| 89 | public function it_should_specify_path_source_and_be_able_to_retrieve_text() | |
| 90 | { | |
| 91 | Storage::fake('s3'); | |
| 92 | ||
| 93 | $converter = new PollyConverter($this->client); | |
| 94 | ||
| 95 | $path = $converter->disk('local') | |
| 87 | /** @test */ | |
| 88 | public function it_should_specify_path_source_and_be_able_to_retrieve_text() | |
| 89 | { | |
| 90 | Storage::fake('s3'); | |
| 91 | ||
| 92 | $converter = new PollyConverter($this->client); | |
| 93 | ||
| 94 | $path = $converter->disk('local') | |
| 96 | 95 | ->source('path') |
| 97 | 96 | ->convert('tests/TestFiles/test.txt'); |
| 98 | ||
| 99 | Storage::assertExists($path); | |
| 100 | } | |
| 97 | ||
| 98 | Storage::assertExists($path); | |
| 99 | } | |
| 101 | 100 | } |