ReviewOS

also looking at this

meemalabs/laravel-meema

Initial Progress

#2
Merged glennmichael123 wants to merge initial-progress into main
11 files +235 -34

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

src/Contracts/FolderInterface.phpmodified+10-10
Changes to src/Contracts/FolderInterface.php
@@ -9,7 +9,7 @@ interface FolderInterface
99 *
1010 * @return array
1111 */
12 public function all(): array;
12 public static function all(): array;
1313
1414 /**
1515 * Get specific folders.
@@ -18,7 +18,7 @@ interface FolderInterface
1818 *
1919 * @return array
2020 */
21 public function get($id = null): array;
21 public static function get($id = null): array;
2222
2323 /**
2424 * Search for specific folders.
@@ -27,7 +27,7 @@ interface FolderInterface
2727 *
2828 * @return array
2929 */
30 public function search($query): array;
30 public static function search($query): array;
3131
3232 /**
3333 * Get specific folders.
@@ -36,7 +36,7 @@ interface FolderInterface
3636 *
3737 * @return Response
3838 */
39 public function find($id): array;
39 public static function find($id): array;
4040
4141 /**
4242 * Create folder.
@@ -45,7 +45,7 @@ interface FolderInterface
4545 *
4646 * @return array
4747 */
48 public function create($name): array;
48 public static function create($name): array;
4949
5050 /**
5151 * Update folder.
@@ -55,7 +55,7 @@ interface FolderInterface
5555 *
5656 * @return array
5757 */
58 public function update($id, $name): array;
58 public static function update($id, $name): array;
5959
6060 /**
6161 * Delete a folder.
@@ -64,7 +64,7 @@ interface FolderInterface
6464 *
6565 * @return null
6666 */
67 public function delete($ids);
67 public static function delete($ids);
6868
6969 /**
7070 * Archive a folder.
@@ -73,7 +73,7 @@ interface FolderInterface
7373 *
7474 * @return array
7575 */
76 public function archive($ids): array;
76 public static function archive($ids): array;
7777
7878 /**
7979 * Unarchive a folder.
@@ -82,7 +82,7 @@ interface FolderInterface
8282 *
8383 * @return array
8484 */
85 public function unarchive($ids): array;
85 public static function unarchive($ids): array;
8686
8787 /**
8888 * Duplicate a folder.
@@ -91,5 +91,5 @@ interface FolderInterface
9191 *
9292 * @return array
9393 */
94 public function duplicate($ids): array;
94 public static function duplicate($ids): array;
9595}
src/Contracts/MediaInterface.phpmodified+13-13
Changes to src/Contracts/MediaInterface.php
@@ -9,7 +9,7 @@ interface MediaInterface
99 *
1010 * @return array
1111 */
12 public function all(): array;
12 public static function all(): array;
1313
1414 /**
1515 * Get specific media.
@@ -18,7 +18,7 @@ interface MediaInterface
1818 *
1919 * @return array
2020 */
21 public function get($ids = null): array;
21 public static function get($ids = null): array;
2222
2323 /**
2424 * Search for specific media.
@@ -27,7 +27,7 @@ interface MediaInterface
2727 *
2828 * @return array
2929 */
30 public function search($query): array;
30 public static function search($query): array;
3131
3232 /**
3333 * Get specific media.
@@ -36,7 +36,7 @@ interface MediaInterface
3636 *
3737 * @return array
3838 */
39 public function find($id): array;
39 public static function find($id): array;
4040
4141 /**
4242 * Create media.
@@ -45,7 +45,7 @@ interface MediaInterface
4545 *
4646 * @return array
4747 */
48 public function create($name): array;
48 public static function create($name): array;
4949
5050 /**
5151 * Update media.
@@ -55,7 +55,7 @@ interface MediaInterface
5555 *
5656 * @return array
5757 */
58 public function update($id, $name): array;
58 public static function update($id, $name): array;
5959
6060 /**
6161 * Delete a media.
@@ -64,7 +64,7 @@ interface MediaInterface
6464 *
6565 * @return null
6666 */
67 public function delete($ids);
67 public static function delete($ids);
6868
6969 /**
7070 * Upload a media file.
@@ -73,7 +73,7 @@ interface MediaInterface
7373 *
7474 * @return array
7575 */
76 public function upload($path): array;
76 public static function upload($path): array;
7777
7878 /**
7979 * Archive a media.
@@ -82,7 +82,7 @@ interface MediaInterface
8282 *
8383 * @return array
8484 */
85 public function archive($ids): array;
85 public static function archive($ids): array;
8686
8787 /**
8888 * Unarchive a media.
@@ -91,7 +91,7 @@ interface MediaInterface
9191 *
9292 * @return array
9393 */
94 public function unarchive($ids): array;
94 public static function unarchive($ids): array;
9595
9696 /**
9797 * Make a media private.
@@ -100,7 +100,7 @@ interface MediaInterface
100100 *
101101 * @return array
102102 */
103 public function makePrivate($ids): array;
103 public static function makePrivate($ids): array;
104104
105105 /**
106106 * Make a media public.
@@ -109,7 +109,7 @@ interface MediaInterface
109109 *
110110 * @return array
111111 */
112 public function makePublic($ids): array;
112 public static function makePublic($ids): array;
113113
114114 /**
115115 * Duplicate a media.
@@ -118,5 +118,5 @@ interface MediaInterface
118118 *
119119 * @return array
120120 */
121 public function duplicate($ids): array;
121 public static function duplicate($ids): array;
122122}
src/Contracts/TagInterface.phpmodified+5-5
Changes to src/Contracts/TagInterface.php
@@ -9,7 +9,7 @@ interface TagInterface
99 *
1010 * @return array
1111 */
12 public function all(): array;
12 public static function all(): array;
1313
1414 /**
1515 * Get specific tags.
@@ -18,7 +18,7 @@ interface TagInterface
1818 *
1919 * @return array
2020 */
21 public function get($ids = null): array;
21 public static function get($ids = null): array;
2222
2323 /**
2424 * Get specific tags.
@@ -27,7 +27,7 @@ interface TagInterface
2727 *
2828 * @return array
2929 */
30 public function find($id): array;
30 public static function find($id): array;
3131
3232 /**
3333 * Update a tag color.
@@ -37,7 +37,7 @@ interface TagInterface
3737 *
3838 * @return array
3939 */
40 public function update($id, $color): array;
40 public static function update($id, $color): array;
4141
4242 /**
4343 * Delete tags.
@@ -46,5 +46,5 @@ interface TagInterface
4646 *
4747 * @return null
4848 */
49 public function delete($ids);
49 public static function delete($ids);
5050}
src/Facades/MeemaFavorite.phpmodified+2-2
Changes to src/Facades/MeemaFavorite.php
@@ -3,7 +3,7 @@
33namespace Meema\LaravelMeema\Facades;
44
55use Illuminate\Support\Facades\Facade;
6use Meema\LaravelMeema\Contracts\FavoriteInterface;
6use Meema\LaravelMeema\Models\Favorite;
77
88class MeemaFavorite extends Facade
99{
@@ -14,6 +14,6 @@ class MeemaFavorite extends Facade
1414 */
1515 protected static function getFacadeAccessor()
1616 {
17 return FavoriteInterface::class;
17 return Favorite::class;
1818 }
1919}
src/Facades/MeemaFolder.phpmodified+2-2
Changes to src/Facades/MeemaFolder.php
@@ -3,7 +3,7 @@
33namespace Meema\LaravelMeema\Facades;
44
55use Illuminate\Support\Facades\Facade;
6use Meema\LaravelMeema\Contracts\FolderInterface;
6use Meema\LaravelMeema\Models\Folder;
77
88class MeemaFolder extends Facade
99{
@@ -14,6 +14,6 @@ class MeemaFolder extends Facade
1414 */
1515 protected static function getFacadeAccessor()
1616 {
17 return FolderInterface::class;
17 return Folder::class;
1818 }
1919}
src/Facades/MeemaMedia.phpmodified+2-2
Changes to src/Facades/MeemaMedia.php
@@ -3,7 +3,7 @@
33namespace Meema\LaravelMeema\Facades;
44
55use Illuminate\Support\Facades\Facade;
6use Meema\LaravelMeema\Contracts\MediaInterface;
6use Meema\LaravelMeema\Models\Media;
77
88class MeemaMedia extends Facade
99{
@@ -14,6 +14,6 @@ class MeemaMedia extends Facade
1414 */
1515 protected static function getFacadeAccessor()
1616 {
17 return MediaInterface::class;
17 return Media::class;
1818 }
1919}
src/Facades/MeemaTag.phpmodified+2-2
Changes to src/Facades/MeemaTag.php
@@ -3,7 +3,7 @@
33namespace Meema\LaravelMeema\Facades;
44
55use Illuminate\Support\Facades\Facade;
6use Meema\LaravelMeema\Contracts\TagInterface;
6use Meema\LaravelMeema\Models\Tag;
77
88class MeemaTag extends Facade
99{
@@ -14,6 +14,6 @@ class MeemaTag extends Facade
1414 */
1515 protected static function getFacadeAccessor()
1616 {
17 return TagInterface::class;
17 return Tag::class;
1818 }
1919}
src/Models/Favorite.phpadded+79-0
Changes to src/Models/Favorite.php
@@ -0,0 +1,79 @@
1<?php
2
3namespace Meema\LaravelMeema\Models;
4
5use Meema\LaravelMeema\Contracts\FavoriteInterface;
6
7class Favorite implements FavoriteInterface
8{
9 /**
10 * List all favorites.
11 *
12 * @return array
13 */
14 public function all(): array
15 {
16 return [];
17 }
18
19 /**
20 * Get specific favorites.
21 *
22 * @param array $ids
23 *
24 * @return array
25 */
26 public function get($ids = null): array
27 {
28 return [];
29 }
30
31 /**
32 * Get specific favorites.
33 *
34 * @param int $id
35 *
36 * @return array
37 */
38 public function find($id): array
39 {
40 return [];
41 }
42
43 /**
44 * Create favorite.
45 *
46 * @param array $data
47 *
48 * @return array
49 */
50 public function create($data): array
51 {
52 return [];
53 }
54
55 /**
56 * Update favorite.
57 *
58 * @param int $id
59 * @param string $data
60 *
61 * @return array
62 */
63 public function update($id, $data): array
64 {
65 return [];
66 }
67
68 /**
69 * Delete a favorite.
70 *
71 * @param array $ids
72 *
73 * @return null
74 */
75 public function delete($ids)
76 {
77 return;
78 }
79}
src/Contracts/FolderInterface.php src/Models/Folder.phpcopied+44-12
Changes to src/Models/Folder.php
@@ -1,15 +1,20 @@
11<?php
22
3namespace Meema\LaravelMeema\Contracts;
3namespace Meema\LaravelMeema\Models;
44
5interface FolderInterface
5use Meema\LaravelMeema\Contracts\FolderInterface;
6
7class Folder implements FolderInterface
68{
79 /**
810 * List all folders.
911 *
1012 * @return array
1113 */
12 public function all(): array;
14 public static function all(): array
15 {
16 return [];
17 }
1318
1419 /**
1520 * Get specific folders.
@@ -18,7 +23,10 @@ interface FolderInterface
1823 *
1924 * @return array
2025 */
21 public function get($id = null): array;
26 public static function get($id = null): array
27 {
28 return [];
29 }
2230
2331 /**
2432 * Search for specific folders.
@@ -27,7 +35,10 @@ interface FolderInterface
2735 *
2836 * @return array
2937 */
30 public function search($query): array;
38 public static function search($query): array
39 {
40 return [];
41 }
3142
3243 /**
3344 * Get specific folders.
@@ -36,7 +47,10 @@ interface FolderInterface
3647 *
3748 * @return Response
3849 */
39 public function find($id): array;
50 public static function find($id): array
51 {
52 return [];
53 }
4054
4155 /**
4256 * Create folder.
@@ -45,7 +59,10 @@ interface FolderInterface
4559 *
4660 * @return array
4761 */
48 public function create($name): array;
62 public static function create($name): array
63 {
64 return [];
65 }
4966
5067 /**
5168 * Update folder.
@@ -55,7 +72,10 @@ interface FolderInterface
5572 *
5673 * @return array
5774 */
58 public function update($id, $name): array;
75 public static function update($id, $name): array
76 {
77 return [];
78 }
5979
6080 /**
6181 * Delete a folder.
@@ -64,7 +84,10 @@ interface FolderInterface
6484 *
6585 * @return null
6686 */
67 public function delete($ids);
87 public static function delete($ids)
88 {
89 return;
90 }
6891
6992 /**
7093 * Archive a folder.
@@ -73,7 +96,10 @@ interface FolderInterface
7396 *
7497 * @return array
7598 */
76 public function archive($ids): array;
99 public static function archive($ids): array
100 {
101 return [];
102 }
77103
78104 /**
79105 * Unarchive a folder.
@@ -82,7 +108,10 @@ interface FolderInterface
82108 *
83109 * @return array
84110 */
85 public function unarchive($ids): array;
111 public static function unarchive($ids): array
112 {
113 return [];
114 }
86115
87116 /**
88117 * Duplicate a folder.
@@ -91,5 +120,8 @@ interface FolderInterface
91120 *
92121 * @return array
93122 */
94 public function duplicate($ids): array;
123 public static function duplicate($ids): array
124 {
125 return [];
126 }
95127}
src/Contracts/MediaInterface.php src/Models/Media.phpcopied+56-15
Changes to src/Models/Media.php
@@ -1,15 +1,20 @@
11<?php
22
3namespace Meema\LaravelMeema\Contracts;
3namespace Meema\LaravelMeema\Models;
44
5interface MediaInterface
5use Meema\LaravelMeema\Contracts\MediaInterface;
6
7class Media implements MediaInterface
68{
79 /**
810 * List all media.
911 *
1012 * @return array
1113 */
12 public function all(): array;
14 public static function all(): array
15 {
16 return [];
17 }
1318
1419 /**
1520 * Get specific media.
@@ -18,7 +23,10 @@ interface MediaInterface
1823 *
1924 * @return array
2025 */
21 public function get($ids = null): array;
26 public static function get($ids = null): array
27 {
28 return [];
29 }
2230
2331 /**
2432 * Search for specific media.
@@ -27,7 +35,10 @@ interface MediaInterface
2735 *
2836 * @return array
2937 */
30 public function search($query): array;
38 public static function search($query): array
39 {
40 return [];
41 }
3142
3243 /**
3344 * Get specific media.
@@ -36,7 +47,10 @@ interface MediaInterface
3647 *
3748 * @return array
3849 */
39 public function find($id): array;
50 public static function find($id): array
51 {
52 return [];
53 }
4054
4155 /**
4256 * Create media.
@@ -45,7 +59,10 @@ interface MediaInterface
4559 *
4660 * @return array
4761 */
48 public function create($name): array;
62 public static function create($name): array
63 {
64 return [];
65 }
4966
5067 /**
5168 * Update media.
@@ -55,7 +72,10 @@ interface MediaInterface
5572 *
5673 * @return array
5774 */
58 public function update($id, $name): array;
75 public static function update($id, $name): array
76 {
77 return [];
78 }
5979
6080 /**
6181 * Delete a media.
@@ -64,7 +84,10 @@ interface MediaInterface
6484 *
6585 * @return null
6686 */
67 public function delete($ids);
87 public static function delete($ids)
88 {
89 return;
90 }
6891
6992 /**
7093 * Upload a media file.
@@ -73,7 +96,10 @@ interface MediaInterface
7396 *
7497 * @return array
7598 */
76 public function upload($path): array;
99 public static function upload($path): array
100 {
101 return [];
102 }
77103
78104 /**
79105 * Archive a media.
@@ -82,7 +108,10 @@ interface MediaInterface
82108 *
83109 * @return array
84110 */
85 public function archive($ids): array;
111 public static function archive($ids): array
112 {
113 return [];
114 }
86115
87116 /**
88117 * Unarchive a media.
@@ -91,7 +120,10 @@ interface MediaInterface
91120 *
92121 * @return array
93122 */
94 public function unarchive($ids): array;
123 public static function unarchive($ids): array
124 {
125 return [];
126 }
95127
96128 /**
97129 * Make a media private.
@@ -100,7 +132,10 @@ interface MediaInterface
100132 *
101133 * @return array
102134 */
103 public function makePrivate($ids): array;
135 public static function makePrivate($ids): array
136 {
137 return [];
138 }
104139
105140 /**
106141 * Make a media public.
@@ -109,7 +144,10 @@ interface MediaInterface
109144 *
110145 * @return array
111146 */
112 public function makePublic($ids): array;
147 public static function makePublic($ids): array
148 {
149 return [];
150 }
113151
114152 /**
115153 * Duplicate a media.
@@ -118,5 +156,8 @@ interface MediaInterface
118156 *
119157 * @return array
120158 */
121 public function duplicate($ids): array;
159 public static function duplicate($ids): array
160 {
161 return [];
162 }
122163}
src/Contracts/TagInterface.php src/Models/Tag.phpcopied+24-7
Changes to src/Models/Tag.php
@@ -1,15 +1,20 @@
11<?php
22
3namespace Meema\LaravelMeema\Contracts;
3namespace Meema\LaravelMeema\Models;
44
5interface TagInterface
5use Meema\LaravelMeema\Contracts\TagInterface;
6
7class Tag implements TagInterface
68{
79 /**
810 * List all tags.
911 *
1012 * @return array
1113 */
12 public function all(): array;
14 public static function all(): array
15 {
16 return [];
17 }
1318
1419 /**
1520 * Get specific tags.
@@ -18,7 +23,10 @@ interface TagInterface
1823 *
1924 * @return array
2025 */
21 public function get($ids = null): array;
26 public static function get($ids = null): array
27 {
28 return [];
29 }
2230
2331 /**
2432 * Get specific tags.
@@ -27,7 +35,10 @@ interface TagInterface
2735 *
2836 * @return array
2937 */
30 public function find($id): array;
38 public static function find($id): array
39 {
40 return [];
41 }
3142
3243 /**
3344 * Update a tag color.
@@ -37,7 +48,10 @@ interface TagInterface
3748 *
3849 * @return array
3950 */
40 public function update($id, $color): array;
51 public static function update($id, $color): array
52 {
53 return [];
54 }
4155
4256 /**
4357 * Delete tags.
@@ -46,5 +60,8 @@ interface TagInterface
4660 *
4761 * @return null
4862 */
49 public function delete($ids);
63 public static function delete($ids)
64 {
65 return [];
66 }
5067}