ReviewOS

also looking at this

meemalabs/laravel-meema

[WIP] Implementing full feature

#1
Closed harlekoy wants to merge develop into main
4 files +15 -53
composer.jsonmodified+8-1
Changes to composer.json
@@ -18,7 +18,8 @@
1818 }
1919 ],
2020 "require": {
21 "php": "^7.3"
21 "php": "^7.3",
22 "meema/flysystem-meema": "dev-master"
2223 },
2324 "require-dev": {
2425 "symfony/var-dumper": "^4.3",
@@ -38,6 +39,12 @@
3839 "test": "vendor/bin/phpunit",
3940 "test-coverage": "vendor/bin/phpunit --coverage-html coverage"
4041 },
42 "repositories": [
43 {
44 "type": "path",
45 "url": "../flysystem-meema"
46 }
47 ],
4148 "config": {
4249 "sort-packages": true
4350 },
src/MeemaClass.phpdeleted+0-25
Changes to src/MeemaClass.php
@@ -1,25 +0,0 @@
1<?php
2
3namespace Meema\LaravelMeema;
4
5class MeemaClass
6{
7 /**
8 * Create a new Laravel File Preview Instance.
9 */
10 public function __construct()
11 {
12 // constructor body
13 }
14
15 /**
16 * Friendly welcome.
17 *
18 * @param string $phrase Phrase to return
19 * @return string Returns the phrase passed in
20 */
21 public function echoPhrase($phrase)
22 {
23 return $phrase;
24 }
25}
src/MeemaFacade.phpdeleted+0-21
Changes to src/MeemaFacade.php
@@ -1,21 +0,0 @@
1<?php
2
3namespace Meema\LaravelMeema;
4
5use Illuminate\Support\Facades\Facade;
6
7/**
8 * @see \Meema\LaravelMeema\MeemaClass
9 */
10class MeemaFacade extends Facade
11{
12 /**
13 * Get the registered name of the component.
14 *
15 * @return string
16 */
17 protected static function getFacadeAccessor()
18 {
19 return 'meema';
20 }
21}
src/MeemaServiceProvider.phpmodified+7-6
Changes to src/MeemaServiceProvider.php
@@ -3,6 +3,9 @@
33namespace Meema\LaravelMeema;
44
55use Illuminate\Support\ServiceProvider;
6use League\Flysystem\Filesystem;
7use Meema\FlysystemMeema\MeemaAdapter;
8use Storage;
69
710class MeemaServiceProvider extends ServiceProvider
811{
@@ -11,11 +14,9 @@ class MeemaServiceProvider extends ServiceProvider
1114 */
1215 public function boot()
1316 {
14 if ($this->app->runningInConsole()) {
15 $this->publishes([
16 __DIR__.'/../config/config.php' => config_path('meema.php'),
17 ], 'config');
18 }
17 Storage::extend('meema', function ($app, $config) {
18 return new Filesystem(new MeemaAdapter($config));
19 });
1920 }
2021
2122 /**
@@ -23,6 +24,6 @@ class MeemaServiceProvider extends ServiceProvider
2324 */
2425 public function register()
2526 {
26 $this->mergeConfigFrom(__DIR__.'/../config/config.php', 'meema');
27 //
2728 }
2829}