ReviewOS

also looking at this

meemalabs/laravel-media-converter

Apply fixes from StyleCI

#28
Merged chris wants to merge analysis-e75dv7 into renovate/configure
7 files +47 -44
src/Contracts/Converter.phpmodifiedformatting only+16-16
Changes to src/Contracts/Converter.php
@@ -7,8 +7,8 @@ interface Converter
77 /**
88 * Sets the path of the file input.
99 *
10 * @param string $path
11 * @param string|null $bucket
10 * @param string $path
11 * @param string|null $bucket
1212 * @return \Meema\MediaConverter\Converters\MediaConvert
1313 */
1414 public function path(string $path, $bucket = null);
@@ -23,12 +23,12 @@ interface Converter
2323 /**
2424 * Sets the settings required to generate the proper amount of thumbnails.
2525 *
26 * @param int $framerateNumerator
27 * @param int $framerateDenominator
28 * @param int $maxCaptures
29 * @param int|null $width
30 * @param string|null $nameModifier
31 * @param int $imageQuality
26 * @param int $framerateNumerator
27 * @param int $framerateDenominator
28 * @param int $maxCaptures
29 * @param int|null $width
30 * @param string|null $nameModifier
31 * @param int $imageQuality
3232 * @return \Meema\MediaConverter\Converters\MediaConvert
3333 */
3434 public function withThumbnails(int $framerateNumerator, int $framerateDenominator, int $maxCaptures, $width = null, $nameModifier = null, $imageQuality = 80);
@@ -36,8 +36,8 @@ interface Converter
3636 /**
3737 * Sets the path & executes the job.
3838 *
39 * @param string $s3Path
40 * @param string|null $s3bucket
39 * @param string $s3Path
40 * @param string|null $s3bucket
4141 * @return \Aws\Result
4242 */
4343 public function saveTo(string $s3Path, $s3bucket = null);
@@ -45,7 +45,7 @@ interface Converter
4545 /**
4646 * Cancels an active job.
4747 *
48 * @param string $id
48 * @param string $id
4949 * @return \Aws\Result
5050 */
5151 public function cancelJob(string $id);
@@ -53,9 +53,9 @@ interface Converter
5353 /**
5454 * Creates a new job based on the settings passed.
5555 *
56 * @param array $settings
57 * @param array $metaData
58 * @param int $priority
56 * @param array $settings
57 * @param array $metaData
58 * @param int $priority
5959 * @return \Aws\Result
6060 */
6161 public function createJob(array $settings, array $metaData, array $tags, int $priority);
@@ -63,7 +63,7 @@ interface Converter
6363 /**
6464 * Gets the job.
6565 *
66 * @param string $id
66 * @param string $id
6767 * @return \Aws\Result
6868 */
6969 public function getJob(string $id);
@@ -71,7 +71,7 @@ interface Converter
7171 /**
7272 * Lists all of the jobs based on your options provided.
7373 *
74 * @param array $options
74 * @param array $options
7575 * @return \Aws\Result
7676 */
7777 public function listJobs(array $options);
src/Converters/MediaConvert.phpmodifiedformatting only+19-19
Changes to src/Converters/MediaConvert.php
@@ -25,7 +25,7 @@ class MediaConvert implements Converter
2525 /**
2626 * Construct converter.
2727 *
28 * @param \Aws\MediaConvert\MediaConvertClient $client
28 * @param \Aws\MediaConvert\MediaConvertClient $client
2929 */
3030 public function __construct(MediaConvertClient $client)
3131 {
@@ -54,8 +54,8 @@ class MediaConvert implements Converter
5454 /**
5555 * Sets the path of the file input.
5656 *
57 * @param string $path - represents the S3 path, e.g path/to/file.mp4
58 * @param string|null $bucket - reference to the S3 Bucket name. Defaults to config value.
57 * @param string $path - represents the S3 path, e.g path/to/file.mp4
58 * @param string|null $bucket - reference to the S3 Bucket name. Defaults to config value.
5959 * @return \Meema\MediaConverter\Converters\MediaConvert
6060 */
6161 public function path(string $path, $bucket = null): MediaConvert
@@ -80,12 +80,12 @@ class MediaConvert implements Converter
8080 /**
8181 * Sets the settings required to generate the proper amount of thumbnails.
8282 *
83 * @param int $framerateNumerator
84 * @param int $framerateDenominator
85 * @param int $maxCaptures
86 * @param int|null $width
87 * @param string|null $nameModifier
88 * @param int $imageQuality
83 * @param int $framerateNumerator
84 * @param int $framerateDenominator
85 * @param int $maxCaptures
86 * @param int|null $width
87 * @param string|null $nameModifier
88 * @param int $imageQuality
8989 * @return \Meema\MediaConverter\Converters\MediaConvert
9090 */
9191 public function withThumbnails(int $framerateNumerator, int $framerateDenominator, int $maxCaptures, $width = null, $nameModifier = null, $imageQuality = 80): MediaConvert
@@ -111,8 +111,8 @@ class MediaConvert implements Converter
111111 /**
112112 * Sets the S3 path & executes the job.
113113 *
114 * @param string $s3Path
115 * @param string|null $s3bucket
114 * @param string $s3Path
115 * @param string|null $s3bucket
116116 * @return \Meema\MediaConverter\Converters\MediaConvert
117117 */
118118 public function saveTo(string $s3Path, $s3bucket = null): MediaConvert
@@ -128,7 +128,7 @@ class MediaConvert implements Converter
128128 /**
129129 * Cancels an active job.
130130 *
131 * @param string $id
131 * @param string $id
132132 * @return \Aws\Result
133133 */
134134 public function cancelJob(string $id)
@@ -141,9 +141,9 @@ class MediaConvert implements Converter
141141 /**
142142 * Creates a new job based on the settings passed.
143143 *
144 * @param array $settings
145 * @param array $metaData
146 * @param int $priority
144 * @param array $settings
145 * @param array $metaData
146 * @param int $priority
147147 * @return \Aws\Result
148148 */
149149 public function createJob(array $settings = [], array $metaData = [], array $tags = [], int $priority = 0)
@@ -166,7 +166,7 @@ class MediaConvert implements Converter
166166 /**
167167 * Gets the job.
168168 *
169 * @param string $id
169 * @param string $id
170170 * @return \Aws\Result
171171 */
172172 public function getJob(string $id)
@@ -179,7 +179,7 @@ class MediaConvert implements Converter
179179 /**
180180 * Lists all of the jobs based on your options provided.
181181 *
182 * @param array $options
182 * @param array $options
183183 * @return \Aws\Result
184184 */
185185 public function listJobs(array $options)
@@ -202,8 +202,8 @@ class MediaConvert implements Converter
202202 /**
203203 * Sets the S3 input file path.
204204 *
205 * @param string $path
206 * @param string|null $bucket
205 * @param string $path
206 * @param string|null $bucket
207207 */
208208 protected function setFileInput(string $path, $bucket = null)
209209 {
src/Http/Controllers/IncomingWebhookController.phpmodified+1-0
Changes to src/Http/Controllers/IncomingWebhookController.php
@@ -56,6 +56,7 @@ class IncomingWebhookController extends Controller
5656 /**
5757 * @param $status
5858 * @param $message
59 *
5960 * @throws \Exception
6061 */
6162 public function fireEventFor($status, $message)
src/Http/Middleware/VerifySignature.phpmodifiedformatting only+2-2
Changes to src/Http/Middleware/VerifySignature.php
@@ -13,8 +13,8 @@ class VerifySignature
1313 /**
1414 * Handle an incoming request.
1515 *
16 * @param Request $request
17 * @param \Closure $next
16 * @param Request $request
17 * @param \Closure $next
1818 * @return mixed
1919 */
2020 public function handle(Request $request, Closure $next)
src/Jobs/CreateVideoConversion.phpmodifiedformatting only+3-3
Changes to src/Jobs/CreateVideoConversion.php
@@ -31,9 +31,9 @@ class CreateVideoConversion implements ShouldQueue
3131 /**
3232 * Create a new job instance.
3333 *
34 * @param array $jobSettings
35 * @param array $tags
36 * @param int $mediaId
34 * @param array $jobSettings
35 * @param array $tags
36 * @param int $mediaId
3737 */
3838 public function __construct($jobSettings, $tags = [], $mediaId = null)
3939 {
src/MediaConverterManager.phpmodified+5-4
formatting only · 8 hidden lines
Changes to src/MediaConverterManager.php
@@ -13,7 +13,7 @@ class MediaConverterManager extends Manager formatting only
1313 /**
1414 * Get a driver instance.
1515 *
16 * @param string|null $name
16 * @param string|null $name
1717 * @return mixed
1818 */
1919 public function engine($name = null)
Changes to src/MediaConverterManager.php
@@ -25,6 +25,7 @@ class MediaConverterManager extends Manager
2525 * Create an Amazon MediaConvert Converter instance.
2626 *
2727 * @return \Meema\MediaConverter\Converters\MediaConvert
28 *
2829 * @throws \Exception
2930 */
3031 public function createMediaConvertDriver(): MediaConvert
formatting only · 10 hidden lines
Changes to src/MediaConverterManager.php
@@ -43,8 +44,8 @@ class MediaConverterManager extends Manager formatting only
4344 /**
4445 * Sets the MediaConvert client.
4546 *
46 * @param array $config
47 * @param Credentials $credentials
47 * @param array $config
48 * @param Credentials $credentials
4849 * @return \Aws\MediaConvert\MediaConvertClient
4950 */
5051 protected function setMediaConvertClient(array $config, Credentials $credentials): MediaConvertClient
formatting only · 8 hidden lines
Changes to src/MediaConverterManager.php
@@ -59,7 +60,7 @@ class MediaConverterManager extends Manager formatting only
5960 /**
6061 * Get credentials of AWS.
6162 *
62 * @param array $credentials
63 * @param array $credentials
6364 * @return \Aws\Credentials\Credentials
6465 */
6566 protected function getCredentials(array $credentials): Credentials
src/Models/MediaConversion.phpmodified+1-0
Changes to src/Models/MediaConversion.php
@@ -18,6 +18,7 @@ use Illuminate\Support\Str;
1818 * @property int|null $percentage_completed
1919 * @property \Illuminate\Support\Carbon|null $created_at
2020 * @property \Illuminate\Support\Carbon|null $updated_at
21 *
2122 * @method static \Illuminate\Database\Eloquent\Builder|MediaConversion newModelQuery()
2223 * @method static \Illuminate\Database\Eloquent\Builder|MediaConversion newQuery()
2324 * @method static \Illuminate\Database\Eloquent\Builder|MediaConversion query()