also looking at this
meemalabs/laravel-media-converter
fix: test cases
#25
2 files
+2
-2
| @@ -117,7 +117,7 @@ class MediaConvert implements Converter | ||
| 117 | 117 | */ |
| 118 | 118 | public function saveTo(string $s3Path, $s3bucket = null): MediaConvert |
| 119 | 119 | { |
| 120 | $destination = 's3://'.($s3bucket ?? config('filesystems.disks.s3.bucket')).$s3Path; | |
| 120 | $destination = 's3://'.($s3bucket ?? config('filesystems.disks.s3.bucket')).'/'.$s3Path; | |
| 121 | 121 | |
| 122 | 122 | $this->jobSettings['OutputGroups'][0]['OutputGroupSettings']['FileGroupSettings']['Destination'] = $destination.'/thumbnails/'; |
| 123 | 123 | $this->jobSettings['OutputGroups'][1]['OutputGroupSettings']['FileGroupSettings']['Destination'] = $destination.'/mp4/'; |
| @@ -59,7 +59,7 @@ it('can successfully update the output path', function () { | ||
| 59 | 59 | ->withThumbnails(1, 2, 3, 100) |
| 60 | 60 | ->saveTo($outputName, $bucket); |
| 61 | 61 | |
| 62 | $destination = 's3://test-bucket'; | |
| 62 | $destination = 's3://test-bucket'.'/'.$outputName; | |
| 63 | 63 | |
| 64 | 64 | $this->assertEquals($converter->jobSettings['OutputGroups'][0]['OutputGroupSettings']['FileGroupSettings']['Destination'], $destination.'/thumbnails/'); |
| 65 | 65 | $this->assertEquals($converter->jobSettings['OutputGroups'][1]['OutputGroupSettings']['FileGroupSettings']['Destination'], $destination.'/mp4/'); |