fix: too few arguments in MediaConvert::createJob()

src/Converters/MediaConvert.phpmodified+5-1

Changes to src/Converters/MediaConvert.php

		⋯145 linesShow the 145 lines above this hunk@@ -146,8 +146,12 @@ class MediaConvert implements Converter
146	146	* @param int $priority
147	147	* @return \Aws\Result
148	148	*/
149		- public function createJob(array $settings, array $metaData = [], array $tags = [], int $priority = 0)
	149	+ public function createJob(array $settings = [], array $metaData = [], array $tags = [], int $priority = 0)
150	150	{
	151	+ if (empty($settings)) {
	152	+ $settings = $this->jobSettings;
	153	+ }
	154	+
151	155	return $this->client->createJob([
152	156	'Role' => config('media-converter.iam_arn'),
153	157	'Settings' => $settings,

src/Support/DefaultMediaConvertJobSettings.phpmodified+0-1

Changes to src/Support/DefaultMediaConvertJobSettings.php

		⋯35 linesShow the 35 lines above this hunk@@ -36,7 +36,6 @@ class DefaultMediaConvertJobSettings
36	36	'ColorMetadata' => 'INSERT',
37	37	'Width' => null, // to be set dynamically
38	38	],
39		- 'NameModifier' => null, // to be set dynamically
40	39	],
41	40	],
42	41	'OutputGroupSettings' => [

tests/MediaConverterTest.phpmodified+16-2

Changes to tests/MediaConverterTest.php

		⋯70 linesShow the 70 lines above this hunk@@ -71,9 +71,23 @@ it('can successfully create a job', function () {
71	71	$this->assertEquals($response['@metadata']['statusCode'], 201);
72	72	});
73	73
74		-it('can successfully get a job', function () {
	74	+it('can successfully create a job chained', function () {
	75	+ $inputName = 'my-video.mkv';
	76	+ $outputName = 'my-video.mp4';
	77	+ $bucket = 'test-bucket';
	78	+
	79	+ $response = MediaConvert::path($inputName, 'test-bucket')
	80	+ ->optimizeForWeb()
	81	+ ->withThumbnails(1, 2, 3, 100)
	82	+ ->saveTo($outputName, $bucket)
	83	+ ->createJob();
	84	+
	85	+ $this->assertEquals($response['@metadata']['statusCode'], 201);
	86	+});
	87	+
	88	+it('can successfully get a jobs', function () {
75	89	// just a hardcoded job ID retrieved from one of the AWS MediaConvert jobs
76		- $jobId = '1615614565083-g1cgjm';
	90	+ $jobId = '1627096589458-nqj4pr';
77	91
78	92	$response = MediaConvert::getJob($jobId);
79	93