ReviewOS

also looking at this

meemalabs/laravel-media-converter

fix: too few arguments in MediaConvert::createJob()

#22
Merged glennmichael123 wants to merge fix-createjob into main
3 files +21 -4
tests/MediaConverterTest.phpmodified+16-2
Changes to tests/MediaConverterTest.php
@@ -71,9 +71,23 @@ it('can successfully create a job', function () {
7171 $this->assertEquals($response['@metadata']['statusCode'], 201);
7272});
7373
74it('can successfully get a job', function () {
74it('can successfully create a job chained', function () {
75 $inputName = 'my-video.mkv';
76 $outputName = 'my-video.mp4';
77 $bucket = 'test-bucket';
78
79 $response = MediaConvert::path($inputName, 'test-bucket')
80 ->optimizeForWeb()
81 ->withThumbnails(1, 2, 3, 100)
82 ->saveTo($outputName, $bucket)
83 ->createJob();
84
85 $this->assertEquals($response['@metadata']['statusCode'], 201);
86});
87
88it('can successfully get a jobs', function () {
7589 // just a hardcoded job ID retrieved from one of the AWS MediaConvert jobs
76 $jobId = '1615614565083-g1cgjm';
90 $jobId = '1627096589458-nqj4pr';
7791
7892 $response = MediaConvert::getJob($jobId);
7993