ReviewOS

also looking at this

meemalabs/laravel-media-converter

fix: add tagging fix

#19
Merged glennmichael123 wants to merge add-tagging-fix into main
1 file +8 -18
src/Jobs/CreateVideoConversion.phpmodified+8-18
Changes to src/Jobs/CreateVideoConversion.php
@@ -19,9 +19,9 @@ class CreateVideoConversion implements ShouldQueue
1919 private array $jobSettings;
2020
2121 /**
22 * @var int
22 * @var array
2323 */
24 private int $mediaId;
24 private int $metaData;
2525
2626 /**
2727 * @var array
@@ -31,18 +31,15 @@ class CreateVideoConversion implements ShouldQueue
3131 /**
3232 * Create a new job instance.
3333 *
34 * @param $jobSettings
35 * @param $tags
36 * @param $mediaId
34 * @param array $jobSettings
35 * @param array $metadata
36 * @param array $tags
3737 */
38 public function __construct($jobSettings, $tags, $mediaId = null)
38 public function __construct($jobSettings, $metaData = [], $tags = [])
3939 {
4040 $this->jobSettings = $jobSettings;
41 $this->metaData = $metaData;
4142 $this->tags = $tags;
42
43 if ($mediaId) {
44 $this->mediaId = $mediaId;
45 }
4643 }
4744
4845 /**
@@ -52,13 +49,6 @@ class CreateVideoConversion implements ShouldQueue
5249 */
5350 public function handle()
5451 {
55 $metaData = [];
56 $tags = $this->tags;
57
58 if ($this->mediaId) {
59 $metaData = ['model_id' => $this->mediaId];
60 }
61
62 MediaConvert::createJob($this->jobSettings, $metaData, $tags);
52 MediaConvert::createJob($this->jobSettings, $this->metaData, $this->tags);
6353 }
6454}