ReviewOS

also looking at this

meemalabs/laravel-media-converter

Read account url from config instead of sending a http request to AWS…

#10
Merged DennisOng wants to merge account-endpoint-via-config into main
3 files +4 -4
README.mdmodified+2-1
Changes to README.md
@@ -50,6 +50,7 @@ Next, please add the following keys their values to your `.env` file.
5050AWS_ACCESS_KEY_ID=xxxxxxx
5151AWS_SECRET_ACCESS_KEY=xxxxxxx
5252AWS_DEFAULT_REGION=us-east-1
53AWS_MEDIACONVERT_ACCOUNT_URL=https://xxxxxxxxx.mediaconvert.us-east-1.amazonaws.com
5354AWS_IAM_ARN=arn:aws:iam::xxxxxxx:role/MediaConvert_Default_Role
5455AWS_QUEUE_ARN=arn:aws:mediaconvert:us-east-1:xxxxxxx:queues/Default
5556```
@@ -70,9 +71,9 @@ return [
7071 'key' => env('AWS_ACCESS_KEY_ID'),
7172 'secret' => env('AWS_SECRET_ACCESS_KEY'),
7273 ],
73
7474 'region' => env('AWS_DEFAULT_REGION', 'us-east-1'),
7575 'version' => 'latest',
76 'url' => env('AWS_MEDIACONVERT_ACCOUNT_URL'),
7677
7778 /**
7879 * Specify the IAM Role ARN.
config/config.phpmodified+1-1
Changes to config/config.php
@@ -13,9 +13,9 @@ return [
1313 'key' => env('AWS_ACCESS_KEY_ID'),
1414 'secret' => env('AWS_SECRET_ACCESS_KEY'),
1515 ],
16
1716 'region' => env('AWS_DEFAULT_REGION', 'us-east-1'),
1817 'version' => 'latest',
18 'url' => env('AWS_MEDIACONVERT_ACCOUNT_URL'),
1919
2020 /**
2121 * Specify the IAM Role ARN.
src/Converters/MediaConverter.phpmodified+1-2
Changes to src/Converters/MediaConverter.php
@@ -22,14 +22,13 @@ class MediaConverter implements Converter
2222 */
2323 public function __construct(MediaConvertClient $client)
2424 {
25 $result = $client->describeEndpoints([]);
2625 $config = config('media-converter');
2726
2827 $this->client = new MediaConvertClient([
2928 'version' => $config['version'],
3029 'region' => $config['region'],
3130 'credentials' => new Credentials($config['credentials']['key'], $config['credentials']['secret']),
32 'endpoint' => $result['Endpoints'][0]['Url'],
31 'endpoint' => $config['url'],
3332 ]);
3433 }
3534