also looking at this
meemalabs/laravel-media-converter
Read account url from config instead of sending a http request to AWS…
#10
3 files
+4
-4
Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.
| @@ -50,7 +50,7 @@ Next, please add the following keys their values to your `.env` file. | ||
| 50 | 50 | AWS_ACCESS_KEY_ID=xxxxxxx |
| 51 | 51 | AWS_SECRET_ACCESS_KEY=xxxxxxx |
| 52 | 52 | AWS_DEFAULT_REGION=us-east-1 |
| 53 | AWS_MEDIA_CONVERT_ACCOUNT_URL=https://xxxxxxxxx.mediaconvert.us-east-1.amazonaws.com | |
| 53 | AWS_MEDIACONVERT_ACCOUNT_URL=https://xxxxxxxxx.mediaconvert.us-east-1.amazonaws.com | |
| 54 | 54 | AWS_IAM_ARN=arn:aws:iam::xxxxxxx:role/MediaConvert_Default_Role |
| 55 | 55 | AWS_QUEUE_ARN=arn:aws:mediaconvert:us-east-1:xxxxxxx:queues/Default |
| 56 | 56 | ``` |
| @@ -73,7 +73,7 @@ return [ | ||
| 73 | 73 | ], |
| 74 | 74 | 'region' => env('AWS_DEFAULT_REGION', 'us-east-1'), |
| 75 | 75 | 'version' => 'latest', |
| 76 | 'url' => env('AWS_MEDIA_CONVERT_ACCOUNT_URL'), | |
| 76 | 'url' => env('AWS_MEDIACONVERT_ACCOUNT_URL'), | |
| 77 | 77 | |
| 78 | 78 | /** |
| 79 | 79 | * Specify the IAM Role ARN. |