ReviewOS

home-lang/home

Account Docker-conditional main Valkey corpus

#323
Closed chris opened this 10 days ago ·
10 days ago

Bun compatibility slice

Port/account js/valkey/valkey.test.ts at exhaustive corpus position 4083.

The main source defines 439 nested Redis/Valkey tests for both TLS and TCP, each inside a Docker-backed describe.skipIf(!isEnabled) container.

Required Home behavior

  • lower and parse the actual complete main source rather than rejecting its shared test-utils import;
  • expose the complete shared binding surface required at module initialization;
  • preserve the exact two suite-level todos (TLS and TCP) when the Docker fixture is unavailable;
  • reuse the structured connection, RESP parser, line-bound, and TLS error components from #315/#318/#320/#322;
  • pin the contract permanently with zero failures and zero unsupported cases.

Tracked from #66.

10 days ago

Implemented and pushed in afef1cd46.

The complete main Valkey source now lowers and parses instead of failing on its shared test-utils and type-only subscriber imports. Home supplies the initialization-time counter, random choice, Docker setup, TCP/TLS URL/options, context, and type helper bindings through the common fixture module; subscriber message imports are correctly erased as types.

With the external Docker fixture unavailable, the 439 nested tests remain behind exactly two suite-level todos—one TLS container and one TCP container—while sharing the permanent Valkey connection, RESP parser, scalar-line, and TLS error components.

Verification:

  • focused position 4083: 0 passed, 2 todos, 0 failed, 0 unsupported;
  • adjacent positions 4082–4083: 7 passed, 2 todos, 0 failed, 0 unsupported;
  • permanent mini-suite and 49 structured-error diagnostics: passed;
  • formatting and diff checks: passed.

Sign in to comment on this issue.