ReviewOS

home-lang/home

Pin conditional Valkey unit corpus contracts

#319
Closed chris opened this 10 days ago ·
10 days ago

Bun compatibility slice

Permanently account exhaustive positions 4075–4079:

  • basic-operations.test.ts;
  • buffer-operations.test.ts;
  • hash-operations.test.ts;
  • list-operations.test.ts;
  • ping.test.ts.

All five actual sources now parse through Home's shared Valkey fixture module and are guarded by Docker-backed describe.skipIf(!isEnabled) suites.

Required Home behavior

  • preserve exactly one suite-level todo per source when the external fixture is unavailable;
  • pin the five-file/zero-pass/five-todo contract in the permanent mini-suite;
  • reuse the structured and secret-redacted Valkey error components from #315/#318;
  • keep zero failures and zero unsupported cases.

Tracked from #66.

10 days ago

Implemented and pushed in 8253a3df2.

The permanent third-party/utility mini-suite now pins all five actual Valkey unit sources at exactly one Docker-conditional suite todo each. Their complete sources already lower through Home's shared Valkey test-utils module; this change makes that five-file boundary a permanent regression contract.

Verification:

  • positions 4075–4079: 5 files, 5 todos, 0 failed, 0 unsupported;
  • permanent mini-suite and 47 structured-error diagnostics: passed;
  • formatting and diff checks: passed.

Sign in to comment on this issue.