ReviewOS

also looking at this

craft-native/craft

fix(svelte): expose public store declaration types

#310
Merged glennmichael123 wants to merge codex/svelte-public-store-types into main
3 files +58 -2
10 days ago

Summary

  • Explicitly expose the public Readable interface from Craft and platform store factories.
  • Avoid generated declarations depending on build-time Svelte helper exports.
  • Add a declaration-generation and strict external-consumer regression test, including read-only and value-type assertions.

This changes no runtime behavior, dependencies, or supported Svelte peer range.

Validation

  • Regression failed before the annotations and passed afterward.
  • All 120 release/harness script tests passed (398 assertions).
  • Svelte package build, Pickier, and git diff checks passed.
  • Fresh packed consumers passed strict declaration checks and SSR probes on supported Svelte 3.59.2 and 4.2.20; an isolated experimental 5.57.1 consumer also passed. This is not a declaration of Svelte 5 support.

3 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.