ReviewOS

craft-native/craft

fix(packaging): preserve application executable names in MSI installs

#12
Closed chris opened this 22 days ago · 2 comments
22 days ago

Problem

The TypeScript MSI packager converts the application name through the WiX identifier sanitizer and reuses that identifier as the installed file name. For craft-lifecycle, the MSI therefore installs craft_lifecycle.exe while the package name and lifecycle API promise craft-lifecycle.exe.

Observed in stacksjs/stacks PR #2064 desktop run 29888261337 on Windows x64.

Required contract

  • Keep WiX XML identifiers sanitized independently from the installed executable file name.
  • Validate the application name before using it as a Windows file name.
  • Install <application name>.exe without converting valid hyphens to underscores.
  • Cover the file name and deterministic WiX source with unit tests.
  • Re-run the native MSI install, launch, update, rollback, and uninstall contract.
22 days ago

Implemented at the core in 5c72c4a and released as Craft v0.0.46 at 83cd027. Unit coverage now keeps Windows file names separate from WiX identifiers, preserves valid hyphens and spaces, and rejects invalid or reserved names. The full Craft suite passes with 450 tests, plus typecheck and build. Stacks PR #2064 pins this exact release and is now running the native Windows lifecycle.

Sign in to comment on this issue.