ReviewOS

also looking at this

zig-utils/zig-js

fix(compat): stop describing ArrayList's layout, and read it instead

#876
Merged glennmichael123 wants to merge fix/zig-1963-arraylist-compat into main
5 files +88 -42
src/jsthread.zigmodified+5-5
Changes to src/jsthread.zig
@@ -1774,7 +1774,7 @@ test "jsthread native private relocation mirrors every traced payload" {
17741774 .release_state = .{ .lock = &lock },
17751775 };
17761776 var pending = [_]*HoldJob{&hold};
1777 lock.pending = .{ .items = &pending, .capacity = pending.len };
1777 lock.pending = .fromOwnedSlice(&pending);
17781778
17791779 var waiter_lock = LockRecord{ .gil = undefined, .owner = &old_objects[4] };
17801780 var waiter = AsyncCondWaiter{ .lock = &waiter_lock, .outer = &old_objects[5] };
@@ -1782,7 +1782,7 @@ test "jsthread native private relocation mirrors every traced payload" {
17821782 var condition = CondRecord{
17831783 .gil = undefined,
17841784 .owner = &old_objects[3],
1785 .queue = .{ .items = &queue, .capacity = queue.len },
1785 .queue = .fromOwnedSlice(&queue),
17861786 };
17871787
17881788 var thread_local = TLRecord{
@@ -1905,7 +1905,7 @@ test "realm root relocation rewrites GIL tasks thread records and property waite
19051905 .release_state = .{ .lock = &lock },
19061906 };
19071907 var task_items = [_]*anyopaque{@ptrCast(&job)};
1908 g.tasks = .{ .items = &task_items, .capacity = task_items.len };
1908 g.tasks = .fromOwnedSlice(&task_items);
19091909
19101910 var queue = promise.MicrotaskQueue{};
19111911 var pending_joins = [_]PendingJoin{.{ .promise = &old_objects[5], .microtasks = &queue }};
@@ -1916,8 +1916,8 @@ test "realm root relocation rewrites GIL tasks thread records and property waite
19161916 .ctx = undefined,
19171917 .result = Value.obj(&old_objects[3]),
19181918 .js_obj = &old_objects[4],
1919 .pending_joins = .{ .items = &pending_joins, .capacity = pending_joins.len },
1920 .settling_joins = .{ .items = &settling_joins, .capacity = settling_joins.len },
1919 .pending_joins = .fromOwnedSlice(&pending_joins),
1920 .settling_joins = .fromOwnedSlice(&settling_joins),
19211921 };
19221922 var ticket = PropAsyncTicket{
19231923 .obj = &old_objects[7],