ReviewOS

stacks/vite-plugin-layouts

Support vite7 and vue-router5

#16
Open seepine opened this 8 days ago ·
8 days ago

Clear and concise description of the problem

├─┬ vite-plugin-layouts 0.1.10
│ ├── ✕ unmet peer vite@"^4.0.0 || ^5.0.0": found 7.3.1
│ └── ✕ unmet peer vue-router@^4.5.1: found 5.0.1

Suggested solution

support it.

Alternative

No response

Additional context

No response

Validations

8 days ago

And the unplugin-vue-router 0.19.2 autogen routes are readonly

Image
8 days ago

@glennmichael123 Do you need some help to add support for vite 7 and vue-router 5 ? I can try create a PR this week about it if you want

8 days ago

@CMarzin please do so 🙏

8 days ago

Hello @glennmichael123 I found the plugin https://github.com/loicduong/vite-plugin-vue-layouts-next Which is a fork from the original vite-plugin-layouts with some fixes and support for vite 8 and vue router 5.

Do you still want to upgrade/maintain this package or we can specify to new user to use the package https://github.com/loicduong/vite-plugin-vue-layouts-next instead ?

If you still want to maintain this package, I can still open a PR for supporting vite 8, vue router 5 and some fixes and improvments from the vite-plugin-vue-layouts-next ?

I wanted you to know but in the repo in examples/vitesse you use another package, the https://github.com/JohnCampionJr/vite-plugin-vue-layouts instead of yours and it works with vite 6.

Using https://github.com/loicduong/vite-plugin-vue-layouts-next fixes my all my problem but since I offered help I can still do something if you want

8 days ago

@CMarzin we want to keep maintaining this package despite the existence of vite-plugin-vue-layouts-next. The goal has always been for us to ship updates fast, but this one slipped under the radar while we were focused on other packages in the ecosystem.

Thanks for flagging the examples/vitesse mixup, that's a genuine oversight on our end, we'll swap it to this plugin.

We'd love your contribution, please go ahead and open the PR whenever it suits you. No rush and we're extremely grateful you offered.

8 days ago

Ok I will try to open a PR this week :)

8 days ago

@CMarzin We're expediting the fix here, so I'll just keep you posted on the updates

Sign in to comment on this issue.