ReviewOS

also looking at this

stacks/ts-qr-codes

chore(deps): update dependency react-dom to 19.2.7

#2138
Closed chris wants to merge buddy-bot/update-major-update-react-dom into main
222 files +16350 -1825

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/qrx/src/config.tsmodified+16-6
Changes to packages/qrx/src/config.ts
@@ -11,7 +11,7 @@ export const defaults: QrxConfig = {
1111 displayValue: true,
1212 fontOptions: '',
1313 font: 'monospace',
14 text: undefined,
14 text: '',
1515 textAlign: 'center',
1616 textPosition: 'bottom',
1717 textMargin: 2,
@@ -24,11 +24,21 @@ export const defaults: QrxConfig = {
2424 marginLeft: undefined,
2525 marginRight: undefined,
2626 valid() { },
27 flat: false,
28 ean128: false,
29 elementTag: 'svg',
2730 },
2831}
32// eslint-disable-next-line import/no-mutable-exports
33export let config: QrxConfig = defaults
34 ; (async () => {
35 config = await loadConfig({
36 name: 'qrx',
37 defaultConfig: defaults,
38 })
39})()
2940
30// eslint-disable-next-line antfu/no-top-level-await
31export const config: QrxConfig = await loadConfig({
32 name: 'qrx',
33 defaultConfig: defaults,
34})
41// export const config: QrxConfig = await loadConfig({
42// name: 'qrx',
43// defaultConfig: defaults,
44// })
packages/qrx/src/types.tsmodified+10-5
Changes to packages/qrx/src/types.ts
@@ -3,6 +3,11 @@ export interface QrxConfig {
33 options: BarcodeConfig | QRCodeConfig
44}
55
6export interface QrxOptions {
7 type?: 'bar' | 'qr'
8 options?: BarcodeOptions | QRCodeOptions
9}
10
611export interface BarcodeSettings {
712 format: string
813 width: string | number
@@ -18,10 +23,10 @@ export interface BarcodeSettings {
1823 background: string
1924 lineColor: string
2025 margin: string | number
21 marginTop: string | number
22 marginBottom: string | number
23 marginLeft: string | number
24 marginRight: string | number
26 marginTop: string | number | undefined
27 marginBottom: string | number | undefined
28 marginLeft: string | number | undefined
29 marginRight: string | number | undefined
2530 flat: boolean
2631 ean128: string | boolean
2732 elementTag: string
@@ -31,7 +36,7 @@ export interface BarcodeSettings {
3136export type BarcodeOptions = Partial<BarcodeSettings>
3237
3338interface NodeConfig extends BarcodeSettings {
34 xmlDocument: XMLDocument
39 xmlDocument?: XMLDocument
3540}
3641
3742export interface NodeOptions extends BarcodeOptions {