ReviewOS

stacks/ts-maps

Bindings: follow mount-only props (maps, provider, position) after mount

#6263
Closed chris opened this 9 days ago ·
9 days ago

In the framework bindings, some options are read only when the component mounts:

  • OfflineMaps: maps, geocoder, resources, position.
  • Search: provider, offline, categories, position.
  • TurnByTurn: profile, units, directions.

Changing them afterwards is ignored. For OfflineMaps, swapping maps after the control was added leaves its listeners on the old manager; the stx test hit this.

Scope

  • Decide per option: follow it by rebuilding the control (position, maps, provider) or by updating it in place (units, categories).
  • Implement it consistently across React, Vue, Svelte, Solid, stx and React Native, with core helpers (e.g. setMaps, setProvider) so the bindings stay thin.
  • Tests per binding.

Sign in to comment on this issue.