ReviewOS

also looking at this

stacks/ts-cloud

fix(ui): stop passing a type argument to a chart helper that has none

#185
Merged glennmichael123 wants to merge fix/charts-line-generic into main
1 file +4 -1

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ui/src/charts.tsmodified+4-1
Changes to packages/ui/src/charts.ts
@@ -111,8 +111,11 @@ export function renderDeploymentSparkline(records: DeploymentPoint[]): string {
111111 record,
112112 }))
113113
114 // `line` is not generic: @ts-charts/shape declares it
115 // `createLine(x?: any, y?: any): any`, so the accessors below carry the
116 // typing instead. It was generic before 0.2.x.
114117 const path =
115 line<any>()
118 line()
116119 .x((d: any) => d.x)
117120 .y((d: any) => d.y)
118121 .curve(curveMonotoneX)(buckets) ?? ''