ReviewOS

also looking at this

stacks/ts-cloud

fix(test): give the last three dashboard integrations a real timeout

#177
Merged glennmichael123 wants to merge fix/dashboard-integration-test-timeouts into main
3 files +15 -3

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/ts-cloud/src/deploy/dashboard-configuration.integration.test.tsmodified+5-1
Changes to packages/ts-cloud/src/deploy/dashboard-configuration.integration.test.ts
@@ -136,5 +136,9 @@ describe('dashboard configuration integration', () => {
136136 body: JSON.stringify({ id: token.id, expectedVersion: 2, confirm: 'TOKEN' }),
137137 })
138138 expect(await removed.json()).toMatchObject({ ok: true, mutation: { removed: ['TOKEN'] } })
139 })
139 // 30s, not the 5000ms default. Booting the dashboard spawns a real
140 // `stx build --no-cache` of the cockpit (~1.7s measured), and this test then
141 // drives import, preview, mask, reveal, rotate, export and delete through it.
142 // ~2s standalone, past 5000ms under the full 313-file run.
143 }, 30_000)
140144})
packages/ts-cloud/src/deploy/dashboard-onboarding.integration.test.tsmodified+5-1
Changes to packages/ts-cloud/src/deploy/dashboard-onboarding.integration.test.ts
@@ -216,5 +216,9 @@ describe('dashboard application onboarding integration', () => {
216216 })
217217 ).json()) as any
218218 expect(disconnected.registry).toMatchObject({ status: 'disconnected', credentialConfigured: false })
219 })
219 // 30s, not the 5000ms default. Booting the dashboard spawns a real
220 // `stx build --no-cache` of the cockpit (~1.7s measured), and this test then
221 // detects, resumes, validates and applies a plan on top of it. ~2s
222 // standalone, past 5000ms under the full 313-file run.
223 }, 30_000)
220224})
packages/ts-cloud/src/deploy/dashboard-source.integration.test.tsmodified+5-1
Changes to packages/ts-cloud/src/deploy/dashboard-source.integration.test.ts
@@ -175,5 +175,9 @@ describe('dashboard source connection integration', () => {
175175 })
176176 ).json()) as any
177177 expect(disconnected.connection).toMatchObject({ status: 'disconnected', credentialConfigured: false })
178 })
178 // 30s, not the 5000ms default. Booting the dashboard spawns a real
179 // `stx build --no-cache` of the cockpit (~1.7s measured) before this test
180 // connects a repository and enqueues a signed deployment. ~2s standalone,
181 // past 5000ms under the full 313-file run.
182 }, 30_000)
179183})