ReviewOS

also looking at this

stacks/ts-analytics

chore: remove subdir-resolve workaround plugin (core handles it now)

#122
Merged glennmichael123 wants to merge chore/remove-subdir-resolve-workaround into main
2 files +6 -17
9 days ago

Removes stx-app-components.plugin.ts — the workaround that registered resources/components as a plugin dir purely to borrow the plugin resolver's recursive walk.

Why it's no longer needed: released stx 0.2.72 searched componentsDir flat (top level only), so subdir kebab tags (<site-selector> → components/dashboard/SiteSelector.stx) never resolved and the dashboard rendered "Error loading component: ENOENT". stx now walks componentsDir recursively in core — stx@d914f3ab83 "feat(stx): walk componentsDir recursively when resolving by tag name" (depth-8, skips node_modules/dotdirs) — so subdir tags resolve natively.

Verified against the installed stx: <site-selector /> resolves with the plugin removed; <Spinner /> still resolves via the kept stx-components.plugin.ts (stx does not auto-resolve the @stacksjs/components library, so that registration stays).

This is the proper fix landing in core instead of an app-level patch (per maintainer feedback).

🤖 Generated with Claude Code

2 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.