ReviewOS

also looking at this

stacks/ts-analytics

refactor: finish DataTable :text → {⁠{ }} migration

#121
Merged glennmichael123 wants to merge refactor/datatable-text-to-mustache into main
1 file +4 -5
9 days ago

Completes the :text → stragglers in DataTable.stx that the original sweep (#120) missed:

  • 4 inline <span :text="…"></span> inside mixed text ("Showing X to Y of Z", "Page X of Y")
  • 2 <span :text="column.label"> / <td :text="…"> (one a multi-line attribute)

Why this one is safe (unlike the @include partials in other repos): DataTable.stx's body keeps :for / :show / :key, so usesSignalsInScript stays true even when the component's <script> is stripped at render time. Verified the are preserved 5/5 server-side.

Context: the broader investigation found is not safe in @include partials/components whose script is stripped before expression processing — see stacksjs/stx#1758. That's why this PR is scoped to just DataTable (which trips the gate via its structural directives).

🤖 Generated with Claude Code

1 changed file on the files tab, with 0 review threads.

Sign in to comment on this pull request.