ReviewOS

stacks/the-settlers-iii-remake

[S3-075] Implement a safe mission and objective runtime

#77
Closed chris opened this 9 days ago ·
9 days ago

S3-075: Implement a safe mission and objective runtime

Parent and ownership

Parent epic: https://github.com/stacksjs/the-settlers-iii-remake/issues/12 Source owner: stacksjs/the-settlers-iii-remake. Master roadmap: https://github.com/stacksjs/the-settlers-iii-remake/issues/4.

Problem and observable result

Execute bounded declarative mission triggers. Persist objectives and scripted-event progress. Reject arbitrary executable imported scripts.

The current application is a browser prototype. Passing the Riverlands campaign does not establish original-game or native parity. This issue is complete only when its stated behavior has retained evidence.

Evidence and interfaces

Decoded mission data drives a bounded declarative objective runtime. Save mission progress with the world. Editing and import/export use the same validated map representation.

Pin the inspected revisions and fixture hashes in the implementation evidence. Original-game observations govern rules and timing. JSettlers is implementation evidence, not an authoritative balance specification. Unknown values remain explicitly unverified.

Acceptance criteria

  • Execute bounded declarative mission triggers.
  • Persist objectives and scripted-event progress.
  • Reject arbitrary executable imported scripts.
  • The visible result agrees with the underlying simulation or platform state, including failure paths.
  • Tests exercise the maintained public interface and retain reproducible fixtures or execution receipts.

Test matrix

  • Save during a multi-stage mission.
  • Reject invalid and cyclic trigger data.
  • Exercise invalid input, cancellation or interruption, and repeated execution where this interface permits them.
  • Verify determinism/conservation for simulation changes and resource ownership/disposal for platform changes.
  • Run owning-repository lint, relevant type checks and tests. Capture actual native output for native capability claims.

Scope constraints

Implement this behavior as a complete verifiable slice. Do not silently expand into adjacent tickets or substitute simplified gameplay. Keep the shared TypeScript simulation, shared stx signals, and ts-css conventions. Native gameplay and HUD must not depend on a WebView. HomeOS reuse must not introduce a kernel dependency into the game. Existing unrelated edits and authored guidance must be preserved.

Blocked by

Upstream release and adoption

Application behavior belongs here. If a reproduction identifies a framework defect, repair and release its owning source first, update Stacks where affected, then install the verified packages here.

No node_modules edits, copied runtimes, generated-source string patches, fabricated globals, successful no-op implementations, or skipped release gates. Push tested conventional commits as Chris to the owning origin/main without coauthor trailers or force pushes.

Completion evidence

  • Implementation commits and relevant upstream issue links.
  • Exact checks and results, fixture hashes, and screenshots/native execution evidence where applicable.
  • Published package versions, downstream lockfile identity, and release receipts when affected.
  • Remaining limitations stated explicitly. Partial work does not close this issue.
9 days ago

Completed: safe mission and objective runtime

  • Missions are validated data (resources/game/engine/mission.ts): objectives plus triggers built from a fixed vocabulary of conditions and actions. Unknown fields, kinds or references, triggers that wait on each other, nesting deeper than eight, and oversized definitions are refused before a session starts. Nothing is ever executed as code.
  • Triggers run in order on a fixed cadence, fire once unless marked to repeat, and their progress is saved, validated on restore and included in the state checksum.
  • Decoded original victory records translate to objectives where their meaning is supported; destroy-building and survive records are reported as unsupported until their semantics are verified (S3-006).

Tests (tests/unit/engine-mission.test.ts): a three-stage mission saved mid-way continues identically and is won; scripts, unknown vocabulary, dangling references, cycles, deep nesting and oversized data are rejected; tampered progress is refused; a player without military buildings is defeated.

Evidence base for this update (all on main, authored as Chris):

  • 3ca4847 deterministic session, rules profile, routing, goods, carriers, construction, production, territory, visibility, saves and replays
  • da2a104 reference building geometry and the delivery livelock fix
  • b2efc1f the browser game on the engine, expanded original-media import
  • 7b1cc36 worlds from decoded original maps
  • a495e7a, 0a3ff46, 0e7889e, e5c1a53, f3b71ce, ed1dc8f controls, missions, render scene, save migration, checkpoints, audit and statistics

Checks: ./buddy lint (0 problems), bun run typecheck (app, tools, stx), ./buddy test --unit (106 tests, 0 failures), bun run assets:verify, bun run content:verify, and the production browser scenario. CI passed on 0e7889e and 9e2ba7c (which contains f3b71ce), including the production Chrome check.

Rule values are the roman-engineering 0.2.0 profile (resources/game/engine/rules.ts). Every value names its evidence class: manual candidates (M) from the pinned manual, reference-remake geometry (E), or placeholders (U) that name their owning issue. qualificationGaps() lists them and the profile cannot qualify a release. Adopting observed original values remains with S3-002/S3-007; nothing here is an original-executable observation.

Sign in to comment on this issue.