ReviewOS

stacks/the-settlers-iii-remake

[S3-049] Implement truthful economy and settler statistics

#51
Open chris opened this 8 days ago ·
8 days ago

S3-049: Implement truthful economy and settler statistics

Parent and ownership

Parent epic: https://github.com/stacksjs/the-settlers-iii-remake/issues/8 Source owner: stacksjs/the-settlers-iii-remake. Master roadmap: https://github.com/stacksjs/the-settlers-iii-remake/issues/4.

Problem and observable result

Derive stock by location and transit. Report production, occupations, and shortages. Calculate supported economic-mode progress.

The current application is a browser prototype. Passing the Riverlands campaign does not establish original-game or native parity. This issue is complete only when its stated behavior has retained evidence.

Evidence and interfaces

Production consumes physically delivered inputs and staffed work. Bounded output inventories create backpressure. Controls change production and carrier decisions rather than settlement totals directly.

Pin the inspected revisions and fixture hashes in the implementation evidence. Original-game observations govern rules and timing. JSettlers is implementation evidence, not an authoritative balance specification. Unknown values remain explicitly unverified.

Acceptance criteria

  • Derive stock by location and transit.
  • Report production, occupations, and shortages.
  • Calculate supported economic-mode progress.
  • The visible result agrees with the underlying simulation or platform state, including failure paths.
  • Tests exercise the maintained public interface and retain reproducible fixtures or execution receipts.

Test matrix

  • Cross-check UI totals against world accounting.
  • Verify hidden and enemy goods stay excluded.
  • Exercise invalid input, cancellation or interruption, and repeated execution where this interface permits them.
  • Verify determinism/conservation for simulation changes and resource ownership/disposal for platform changes.
  • Run owning-repository lint, relevant type checks and tests. Capture actual native output for native capability claims.

Scope constraints

Implement this behavior as a complete verifiable slice. Do not silently expand into adjacent tickets or substitute simplified gameplay. Keep the shared TypeScript simulation, shared stx signals, and ts-css conventions. Native gameplay and HUD must not depend on a WebView. HomeOS reuse must not introduce a kernel dependency into the game. Existing unrelated edits and authored guidance must be preserved.

Blocked by

Upstream release and adoption

Application behavior belongs here. If a reproduction identifies a framework defect, repair and release its owning source first, update Stacks where affected, then install the verified packages here.

No node_modules edits, copied runtimes, generated-source string patches, fabricated globals, successful no-op implementations, or skipped release gates. Push tested conventional commits as Chris to the owning origin/main without coauthor trailers or force pushes.

Completion evidence

  • Implementation commits and relevant upstream issue links.
  • Exact checks and results, fixture hashes, and screenshots/native execution evidence where applicable.
  • Published package versions, downstream lockfile identity, and release receipts when affected.
  • Remaining limitations stated explicitly. Partial work does not close this issue.
8 days ago

Progress (S3-049, still open)

statistics() derives a player's goods by location (loose, doorstep, input, site, stored, carried), production, occupations, shortages and progress toward mission goods goals, from world state only; tests cross-check totals and exclude other players. Economic-mode thresholds are unverified, so the issue stays open.

Implementation: resources/game/engine/production.ts, workforce.ts, logistics.ts; tests in tests/unit/engine-economy.test.ts and tests/unit/engine-audit.test.ts.

Evidence base for this update (all on main, authored as Chris):

  • 3ca4847 deterministic session, rules profile, routing, goods, carriers, construction, production, territory, visibility, saves and replays
  • da2a104 reference building geometry and the delivery livelock fix
  • b2efc1f the browser game on the engine, expanded original-media import
  • 7b1cc36 worlds from decoded original maps
  • a495e7a, 0a3ff46, 0e7889e, e5c1a53, f3b71ce, ed1dc8f controls, missions, render scene, save migration, checkpoints, audit and statistics

Checks: ./buddy lint (0 problems), bun run typecheck (app, tools, stx), ./buddy test --unit (106 tests, 0 failures), bun run assets:verify, bun run content:verify, and the production browser scenario. CI passed on 0e7889e and 9e2ba7c (which contains f3b71ce), including the production Chrome check.

Rule values are the roman-engineering 0.2.0 profile (resources/game/engine/rules.ts). Every value names its evidence class: manual candidates (M) from the pinned manual, reference-remake geometry (E), or placeholders (U) that name their owning issue. qualificationGaps() lists them and the profile cannot qualify a release. Adopting observed original values remains with S3-002/S3-007; nothing here is an original-executable observation.

8 days ago

Browser production accounting is now exercised end to end on main at a12d51e3.

The new tests/browser/production.ts drives the real production app controls: place a sawmill, wait for its assigned sawyer and full output, inspect the production statistics, save and reload. The displayed figures are checked independently: three planks and four stones go into construction, eight starting logs become eight new planks, the settlement holds 35 planks, and the made/stock figures survive reload. The full doorstep stops further production. No game state is injected and the installed runtime is unchanged.

All 19 steps passed locally and in exact-source hosted CI, with no console errors or failed requests. The original hosted campaign-browser-check artifact was downloaded and independently checked against its GitHub SHA256 digest and ZIP CRC; its actual JSON reports confirm the 19 production steps, 58 campaign steps and resize checks. The local production raster was inspected. The committed receipt retains source identities, exact values, capture identity and limits. The new scenario runs in CI alongside the campaign, control-frame, resize and checkpoint scenarios.

This is the Roman engineering 0.7.0 profile, not a measurement from an original executable. Full economic-mode statistics, verified original numeric rules and complete native behavior remain outstanding, so S3-049 stays open. The complete main CI also passed on the same a12d51e source, including the production browser step.

Sign in to comment on this issue.