ReviewOS

stacks/the-settlers-iii-remake

Pause residence arrivals and retain the remaining population timer

#232
Closed chris opened this 19 hours ago ·
19 hours ago

The public residence inspector offers Pause work and reports Work paused, but staff() creates new settlers before checking building suspension. A public-session fixture pauses a small residence at tick 40; its birth ledger still rises from 1 to 3 by tick 440.

Parent: #37 (S3-035 residences and workforce). Related: #35 (pause behavior), #94 (replay), #92 (versioned saves).

Acceptance:

  • Paused residences add no settlers and preserve the remaining arrival interval.
  • Resume continues that interval; repeated pause/resume commands do not reset or double-transform it.
  • The player view and population ledger agree, including save/restore and replay during pause, rejection of foreign ownership, and demolition.
  • Freeze engineering profile 0.16.0 with its unchanged digest; new behavior belongs to a newly evidenced profile so published saves and replays retain their rules.
  • Public-session regressions fail before correction; application lint/types/tests/build/browser gates pass.

This is an engineering correction to the authored pause control. Original Gold resident counts, arrival intervals and residence controls remain unobserved under #37.

19 hours ago

Implemented in afea78e as Chris, without coauthors. A paused residence now retains its remaining arrival interval and creates no settlers until resumed. Repeated controls are idempotent. Engineering profile 0.16.0 remains frozen with its original digest; new games use 0.17.0, preserving older saves and replays.

The public-command regression failed before correction: after pausing at tick 40, births rose from 1 to 3 by tick 440. All 489 unit tests / 85,789 assertions now pass, along with lint (zero problems), app/tools/STX types and production build. Seven dedicated cases cover the clock, duplicate commands, mid-pause save/replay, ownership/type rejection, demolition and legacy behavior.

A real Chrome playthrough built and staffed construction for a small residence from normal supplies. The visible population stayed 39 for 21 game seconds while its inspector reported Work paused, then rose to 40 after Resume work. All 18 browser steps passed without console, network or collection errors. The final raster was inspected privately. The new scenario runs in CI and retains non-media diagnostics.

Retained source and local execution receipt. Hosted CI and the normal protected deployment workflow are running; their completion will be recorded separately. #37 remains open for original Gold residence values and controls.

19 hours ago

Exact source afea78e3e0a6d3da88ce906bd1e57ee97fb12eb0 deployed successfully through protected production run 41392680742. Encrypted configuration checks, normal cutover and the maintained public smoke gate all passed. Rollback was skipped because deployment succeeded.

Independently repeated all ten live public page/image/sign-in-gate checks after deployment. No production account was created. Existing published save profiles retain their original behavior; new 0.17.0 games use the corrected residence pause semantics. Hosted CI 41392644687 is still running its complete 23-suite browser matrix; this remains open pending that gate.

18 hours ago

Exact-source CI 41392644687 passed on afea78e3e0a6d3da88ce906bd1e57ee97fb12eb0, including 489 unit tests and all 23 production browser suites. The same source deployed successfully in production run 41392680742, with public smoke checks passing and rollback skipped.

Independently downloaded original diagnostic artifact 13118304850: GitHub SHA-256 8996fd0fb4c5f13163930118309cdbf1fcff4fc15e1f7cf49663be5fbbe11f71, 47,749 bytes and all ZIP CRCs match. All 1033 browser steps succeeded across all 23 suites, including nested viewport reports; recorded browser process exits were zero and no available console/request/collection error arrays contained entries. The new residence scenario confirms 39 settlers retained for 21 game seconds while work is paused, then 40 after resume, using normal construction supplies and controls. Original-media rasters remain private.

The narrow authored-pause correction is complete. Parent #37 remains open for verified original Gold residence values and controls. Published 0.16.0 save/replay behavior remains frozen; new 0.17.0 games use the correction.

Sign in to comment on this issue.