ReviewOS

also looking at this

stacks/stx

fix(ssr): respect client signal ownership before evaluation

#2100
Merged chris wants to merge codex/client-signal-ssr-ownership into main
2 files +46 -29
8 days ago

Rendering a client signal named post could invoke Stacks’ unrelated auto-imported POST helper on the server before preserving the interpolation. This submitted an undefined URL while rendering editor components and could also affect page-local signals that shadowed server helpers.

Resolve authored client signal ownership before evaluating an interpolation. Reuse the existing signal-declaration analysis for page scripts and inherited component scopes while keeping ordinary server helper evaluation intact.

Validation: page and nested-component regressions reproduce the unintended helper call before the fix and pass afterward. All 16,595 source tests pass (34 existing skips), with 44,443 assertions across 1,249 files. Types, lint and formatting pass. Release preflight passes its builds, installed-package checks, performance budgets and 318 regressions. Full PR CI and the documentation deployment are green.

2 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.