ReviewOS

also looking at this

stacks/stx

fix(native): preserve modal presentation protocol properties

#2099
Merged chris wants to merge codex/native-modal-protocol-props into main
3 files +41 -2
8 days ago

Authored native popups lost nonModal and dismissOnOutsideTap when HTML parsing lowercased their attributes. Craft consequently received blocking modals without outside-tap dismissal. Restore both public property names and their bare boolean handling in the native compiler.

Regressions cover camel-case and kebab-case attributes, explicit false values, and real nested request-close events in minified and unminified bundles. A dismissal closes the requested popup and retains its parent.

Validation: all four new cases fail before the fix. All 16,554 source tests pass, along with formatting, types, release preflight, and every PR CI check. The merged Main source also passes 688 native/scoped-slot tests and release preflight. The normal v0.2.606 release runs its exact-tag gate before publishing.

3 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.