ReviewOS

also looking at this

stacks/stx

fix(native): preserve explicit grid row tracks

#2092
Merged chris wants to merge codex/native-explicit-grid-rows into main
5 files +42 -4
packages/stx/src/native/compiler/inline-style.tsmodified+2-2
Changes to packages/stx/src/native/compiler/inline-style.ts
@@ -2,7 +2,7 @@ import type { STXStyle } from './ir'
22
33/** Every property `STXStyle` declares, for inline `style=""` translation. */
44const STYLE_KEYS = new Set([
5 'display', 'gridColumns', 'gridTemplateColumns', 'gridAutoRows',
5 'display', 'gridColumns', 'gridTemplateColumns', 'gridTemplateRows', 'gridAutoRows',
66 'flex', 'flexGrow', 'flexShrink', 'flexBasis', 'flexDirection', 'flexWrap',
77 'justifyContent', 'alignItems', 'alignSelf', 'alignContent', 'position', 'top', 'right',
88 'bottom', 'left', 'zIndex', 'width', 'height', 'minWidth', 'maxWidth', 'minHeight',
@@ -161,7 +161,7 @@ export function parseNativeStyle(input: unknown, report: (diagnostic: NativeStyl
161161 translated = undefined
162162 }
163163 else if (property === 'shadowOffset' || property === 'transform') translated = structuredStyle(property, value)
164 else if (property === 'gridTemplateColumns') translated = finite(value) || typeof value === 'string' ? value : undefined
164 else if (property === 'gridTemplateColumns' || property === 'gridTemplateRows') translated = finite(value) || typeof value === 'string' ? value : undefined
165165 // Font weights are strings in the IR, even when authored as object numbers.
166166 else if (property === 'fontWeight' && finite(value)) translated = String(value)
167167 else if (typeof value === 'string') translated = value