ReviewOS

also looking at this

stacks/stx

fix(native): preserve explicit grid row tracks

#2092
Merged chris wants to merge codex/native-explicit-grid-rows into main
5 files +42 -4
8 days ago

Native grids authored with gridTemplateRows lose their row definition during compilation, so a two-row grid with a definite height collapses to its intrinsic row heights. Carry explicit row tracks through the native style IR and the shared inline-style normalizer for object, serialized object, CSS, and reactive styles.

The compiled native regression checks the same static style shape used by Craft’s installed fixtures, plus row changes and clearing in minified and development bundles. Craft’s strict iOS and Android track-position assertions remain unchanged.

Validation: 78 focused tests, TypeScript, lint, formatting, and the normal release preflight pass. The preflight includes built archive consumer checks and 318 selected tests. The full local suite passes: 16,363 tests, 34 skips, zero failures, 43,159 assertions across 1,215 files. Compiling and mounting Craft’s actual navigation fixture also preserves repeat(2, 1fr) in its native mutation tree. Hosted lint and types pass; hosted full-suite qualification is pending after the npm propagation failure recovered. This change must qualify before its normal public release and downstream SDK compiler-pin update.

5 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.