ReviewOS

also looking at this

stacks/stx

fix(native): preserve authored keys in mutation nodes

#2084
Closed chris wants to merge codex/native-mutation-authored-keys into main
3 files +77 -3
8 days ago

A conditional native subtree loses its authored reconciliation key when STX emits createNode. The initial rendered tree includes the key, so replacing a View with a SafeAreaView can discard a retained native container after its first update.

Preserve the authored key in the native host descriptor, cloning and rematerialization, and expose that metadata on mutation creation nodes. Keys remain immutable during an update; a key change requires a replacement node.

Two regressions exercise a real minified production bundle across three conditional replacements and native-host cloning/removal/rematerialization. The complete fixed-branch CI passed 16,097 tests with zero failures and the existing 34 skips.

This fix has already been integrated into main and published in STX 0.2.573’s release source. Its actual public archive preserves authored keys and matches registry integrity. Craft’s full native qualification, pinned to that published compiler revision, also passes on iOS and Android. This original branch is closed as completed through that integration.

3 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.