ReviewOS

also looking at this

stacks/stx

style(desktop): format the two files holding the format check red

#1949
Merged glennmichael123 wants to merge fix/desktop-format into main
2 files +30 -29

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

packages/desktop/src/dialogs.tsmodifiedformatting only+5-5
Changes to packages/desktop/src/dialogs.ts
@@ -50,11 +50,11 @@ export interface OpenDialogOptions {
5050
5151/** A behaviour Craft's open panel understands. */
5252export type OpenDialogProperty =
53 | 'openFile'
54 | 'openDirectory'
55 | 'multiSelections'
56 | 'showHiddenFiles'
57 | 'createDirectory'
53| 'openFile'
54| 'openDirectory'
55| 'multiSelections'
56| 'showHiddenFiles'
57| 'createDirectory'
5858
5959/**
6060 * Restate the options in the terms Craft's bridge reads.
packages/desktop/src/menu.tsmodified+25-24
Changes to packages/desktop/src/menu.ts
@@ -61,25 +61,25 @@ import { hasBridge, onCraftEvent } from './_bridge' formatting only
6161 * insensitively; this list is the canonical casing.
6262 */
6363export type MenuRole =
64 | 'about'
65 | 'hide'
66 | 'hideOthers'
67 | 'showAll'
68 | 'quit'
69 | 'undo'
70 | 'redo'
71 | 'cut'
72 | 'copy'
73 | 'paste'
74 | 'delete'
75 | 'selectAll'
76 | 'close'
77 | 'minimize'
78 | 'zoom'
79 | 'front'
80 | 'fullscreen'
81 | 'reload'
82 | 'forceReload'
64| 'about'
65| 'hide'
66| 'hideOthers'
67| 'showAll'
68| 'quit'
69| 'undo'
70| 'redo'
71| 'cut'
72| 'copy'
73| 'paste'
74| 'delete'
75| 'selectAll'
76| 'close'
77| 'minimize'
78| 'zoom'
79| 'front'
80| 'fullscreen'
81| 'reload'
82| 'forceReload'
8383
8484export interface MenuItem {
8585 /** Stable identifier. The same id is reported by `onAction`. */
@@ -297,11 +297,12 @@ export const menu: MenuAPI = {
297297 const { payload, handlers } = extractHandlers(appMenu)
298298
299299 disposeHandlers?.()
300 disposeHandlers = handlers.size > 0
301 ? onCraftEvent<MenuActionEvent>('craft:menu:action', (event) => {
302 handlers.get(event.id)?.()
303 })
304 : null
300 disposeHandlers = null
301 if (handlers.size > 0) {
302 disposeHandlers = onCraftEvent<MenuActionEvent>('craft:menu:action', (event) => {
303 handlers.get(event.id)?.()
304 })
305 }
305306
306307 await window.craft!.menu.set(payload)
307308 return true