also looking at this

Expand BunPress guide and pre-E2E quality gates

#35

Merged glennmichael123 wants to merge docs/bunpress-product-guide into main

40 files +1524 -373

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

tests/feature/reports-surface.test.tsmodified+1-1

@@ -84,7 +84,7 @@ describe('the reports surface', () => {
     for (const page of ['resources/views/reports/index.stx', 'resources/views/reports/[slug].stx']) {
       const source = readFileSync(join(root, page), 'utf8')
 
-      expect(source).toContain('sessionFrom(cookies)')
+      expect(source).toContain("sessionFrom(typeof cookies !== 'undefined' ? cookies : undefined)")
       expect(source).toContain(`
/var/www/reviewos-reviewos/releases/3e057f9/resources/views/layouts/app.stx:3931:6427: include error: Error loading include file AuthGuard: ENOENT: no such file or directory, open '/var/www/reviewos-reviewos/releases/3e057f9/resources/views/partials/AuthGuard.stx'

[1m[31m╭──────────────────────────────────────────────────────────────╮[0m
[1m[31m│[0m [1m[41m ERROR [0m [31mInclude Error[0m                                    [1m[31m│[0m
[1m[31m╰──────────────────────────────────────────────────────────────╯[0m

[36m[1mFile:[0m [2mapp.stx[0m [90m(line 3931, col 6427)[0m
[33m[1mMessage:[0m Error loading include file AuthGuard: ENOENT: no such file or directory, open '/var/www/reviewos-reviewos/releases/3e057f9/resources/views/partials/AuthGuard.stx'

[34m[1mContext:[0m
[2m  3929: 
  3930:             
> 3931:               tests/feature/reports-surface.test.tsmodified+1-1Changes to tests/feature/reports-surface.test.ts@@ -84,7 +84,7 @@ describe('the reports surface', () => {
     for (const page of ['resources/views/reports/index.stx', 'resources/views/reports/[slug].stx']) {
       const source = readFileSync(join(root, page), 'utf8')
 
-      expect(source).toContain('sessionFrom(cookies)')
+      expect(source).toContain("sessionFrom(typeof cookies !== 'undefined' ? cookies : undefined)")
       expect(source).toContain(`
/var/www/reviewos-reviewos/releases/3e057f9/resources/views/layouts/app.stx:4142:17: include error: Error loading include file AuthGuard: ENOENT: no such file or directory, open '/var/www/reviewos-reviewos/releases/3e057f9/resources/views/partials/AuthGuard.stx'

[1m[31m╭──────────────────────────────────────────────────────────────╮[0m
[1m[31m│[0m [1m[41m ERROR [0m [31mInclude Error[0m                                    [1m[31m│[0m
[1m[31m╰──────────────────────────────────────────────────────────────╯[0m

[36m[1mFile:[0m [2mapp.stx[0m [90m(line 4142, col 17)[0m
[33m[1mMessage:[0m Error loading include file AuthGuard: ENOENT: no such file or directory, open '/var/www/reviewos-reviewos/releases/3e057f9/resources/views/partials/AuthGuard.stx'

[34m[1mContext:[0m
[2m  4140:           
  4141:             +16
> 4142:             -8
  4143:           
  4144:         [0m
`)
       expect(source).toContain('auth-required')
       // And the data is fetched only for an identified visitor.

  3932:             
  3933:           [0m
`)
       expect(source).toContain('auth-required')
       // And the data is fetched only for an identified visitor.

@endif