ReviewOS

also looking at this

stacks/pet-store

umbrella: pet-store storefront fixes (rolling)

#3
Merged glennmichael123 wants to merge umbrella/pet-store into main
586 files +38082 -7487

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

storage/framework/core/actions/src/build/core.tsmodified+10-2
Changes to storage/framework/core/actions/src/build/core.ts
@@ -1,5 +1,5 @@
11import { $ } from 'bun'
2import { existsSync, statSync } from 'node:fs'
2import { existsSync, readFileSync, statSync } from 'node:fs'
33import process from 'node:process'
44import { dim, italic, log } from '@stacksjs/cli'
55import { corePath } from '@stacksjs/path'
@@ -16,7 +16,15 @@ const dirs = allEntries.filter((entry) => {
1616 const pkgPath = `${entry}/package.json`
1717 if (!existsSync(pkgPath))
1818 return false
19 return true
19
20 try {
21 const pkg = JSON.parse(readFileSync(pkgPath, 'utf8')) as { scripts?: Record<string, string> }
22 return typeof pkg.scripts?.build === 'string'
23 }
24 catch (error) {
25 log.warn(`Skipping ${italic(dim(entry))}: package.json could not be read`)
26 return false
27 }
2028})
2129
2230if (dirs.length === 0) {