ReviewOS

also looking at this

stacks/pet-store

security: drop plaintext tenant mail passwords from .env.production

#26
Open glennmichael123 wants to merge security/drop-plaintext-tenant-mail-passwords into main
1 file +0 -3
9 days ago

.env.production is committed in this public repo and carried three real per-mailbox SMTP passwords in plaintext — MAIL_PASSWORD_CHRIS, MAIL_PASSWORD_BLAKE, MAIL_PASSWORD_GLENN — readable at HEAD via the raw contents API.

They are not this app's credentials. They came from the stacksjs/stacks scaffold, which ships the same file to every buddy new app. Upstream fix: stacksjs/stacks#2211.

Removing them here does not un-publish them — the passwords need rotating at the mail provider. This stops them being served at HEAD.

No other secret in this file is exposed: everything else is non-secret config or an empty value.

1 changed file on the files tab, with 0 review threads.

Sign in to comment on this pull request.