ReviewOS

stacks/lastsoulultra

Discover drops the entire app navigation for a signed-in person

#21
Open glennmichael123 opened this 4 days ago ·
4 days ago

Going to Discover while signed in replaces the whole app navigation with the marketing header. Home, Classes, Calendar, Plans, Dashboard and More all disappear, and in their place is a "Open app" button, which is odd advice for somebody who is already in the app. There is no way back except the browser's back button.

Reproduced on training.lsu.stacksjs.com/explore, signed in as a demo member. The code is in hq.training.

What is happening

/explore is a public page, not an app page. Its heading comes from the public namespace:

resources/lang/messages/en/public.ts:197   discoverTitle: 'Find your training community'

and the app keeps separate navigation components for the two shells:

resources/components/app-nav.stx
resources/components/marketing-nav.stx
resources/components/workspace-nav.stx
resources/components/enterprise-site-nav.stx

The signed-in pages render app-nav. /explore renders the marketing one, and it does so whether or not there is a session, so following the Discover link from inside the app drops you out of the app shell.

Why it matters here

Discover is linked from the app's own top bar, so this is not an edge case reached from outside. The path is: signed in, click Discover, lose every navigation item, and the only affordance offered is a button inviting you to open the app you are already using.

The page content itself is fine. It is only the shell that is wrong.

What it should do

When there is a session, /explore should render the app shell and keep the top bar, the same way the other signed-in pages do. The marketing header stays correct for signed-out visitors.

Worth checking the other public pages that are reachable from inside the app for the same thing, since the split is per shell rather than per page.

Sign in to comment on this issue.