ReviewOS

also looking at this

stacks/drone

fix: qualify registration expiry across native commit

#75
Merged chris wants to merge codex/registration-commit-boundary into main
2 files +35 -8
9 days ago

Summary

The native registration fixture assumed its afterCommit hook would arrive before a 500 ms deadline. A real delayed native callback can cross expiry after validation and commit successfully, causing the fixture itself to throw before the application can refuse the expired response.

The fixture now verifies committed state through an independent SQLite connection and records both supported expiry phases:

expiry during native commit -> committed source + expired response refused
expiry during response hold -> committed source + expired response refused

It retains result/token/incident lifetime values, precommit rollback checks, exact source/audit/version/refresh-hint assertions and the outer watchdog. A fixed fourth case deliberately crosses expiry at the native callback. At least one genuine response-hold case must also be observed. Per-case receipts are forwarded through the native test harness.

Evidence

  • Before: main workflow 39877819113 failed the fixture's commit-before-deadline assertion. A controlled 600 ms native callback pause reproduces it with one persisted source.
  • After: the corrected original native harness passes all four scope/phase cases. Temporarily removing the production post-COMMIT deadline check fails with Missing expected rejection; production bytes were restored exactly.
  • Buddy Pickier, application types and runtime types pass. Full current-source CI is pending.

The original Linux scope and precise scheduling point remain unknown. Original failure logs and every diagnostic outcome are retained. Related: #74.

Merge Danger

Reversible fixture and test-output changes. Production policy, schema and dependencies are unchanged. The added crossing case uses real elapsed time and does not retry until passing.

2 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.