ReviewOS

also looking at this

stacks/drone

test: retain bounded browser launch evidence on failure

#70
Merged chris wants to merge codex/browser-startup-evidence into main
18 files +620 -23
9 days ago

Browser discovery and later CDP failures previously lost launch evidence when their private fixture was removed. Retain failed private fixtures locally and export fixed-shape launch observations. Startup-only stderr is capped at 65,536 bytes; stderr after a page visit is withheld from public artifacts. CI uploads only two explicitly allowed files.

The launch record distinguishes settled status, signal, observation before cleanup, cleanup request and port-read outcomes. Post-renewal liveness has its own transport label. Original startup polling, CDP deadlines, execution completion guard, renewal interval and process ownership remain unchanged.

This diagnostic change addresses evidence collection for #64 and #44. It does not establish those original failure causes. The combined main-target diff includes #69 runtime cold-build initialization and cleanup qualification.

Validation:

  • Final focused regression: 19 passed, two actual-browser cases skipped, zero failed, 166 assertions. Pickier and application/runtime types passed. Both independent review axes are clean.
  • Actual macOS workspace and execution browser attempts failed with observed child exit 0 before cleanup. Both failed private profiles and original logs remain retained. The reporting path exported launch metadata and withheld post-page stderr. Neither macOS browser scenario passed.
  • Exact-head CI 39843840771 at 1ef2f6a86ed77ae9e7924d4fd3f76ebd19a8648e passed all five Linux jobs, including both real rendered browser campaigns, firmware and namespace. Full Buddy suite: 1,519 passed, 41 skipped, zero failed, 489,307 assertions, 1,560 tests across 198 files in 3,210.49 seconds. All later standalone CLI gates passed. Local Bun 1.4.2 and CI Bun 1.4.3 evidence remain distinguished.
  • The complete terminal log was retained once, 3,081,463 bytes, SHA256 cc486891ca288870412844dd3b48a89cd655db33d1b4984a96546be78872a88b. No failed workflow was restarted.

Published to origin/main at 1ef2f6a86ed77ae9e7924d4fd3f76ebd19a8648e by normal fast-forward as Chris Breuer without coauthors. Original browser and local-suite failure causes remain open. No physical flight or hardware qualification is claimed.

18 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.