ReviewOS

also looking at this

stacks/drone

feat: own runtime firmware candidates

#49
Merged chris wants to merge codex/runtime-candidate-ownership into main
24 files +1245 -92
resources/functions/drone/updates/staging.tsmodified+5-19
Changes to resources/functions/drone/updates/staging.ts
@@ -1,13 +1,14 @@
11import { randomBytes } from 'node:crypto'
22import { mkdirSync, mkdtempSync, realpathSync, rmSync } from 'node:fs'
3import { dirname, join, relative, resolve, sep } from 'node:path'
3import { join, resolve } from 'node:path'
44import { tmpdir } from 'node:os'
55import { Readable } from 'node:stream'
66import { isDeepStrictEqual } from 'node:util'
77import { Updater } from 'tuf-js'
8import { directory, imageLimit, metadataLimit, regularFile, repositoryFile, safePath, sha256, syncDirectory, syncTree, writeExclusive } from './files'
8import { directory, imageLimit, metadataLimit, regularFile, repositoryFile, safePath, sha256, writeExclusive } from './files'
99import { object, validateMetadata } from './metadata'
1010import { admitSignedRuntime } from './manifest'
11import { finishRuntimeCandidate, runtimeCandidateOutput } from './candidate-files'
1112import { admitPolicy } from './policy'
1213import type { RuntimeFirmwarePolicy } from './policy'
1314export type { RuntimeFirmwarePolicy } from './policy'
@@ -85,29 +86,14 @@ async function verifyRepository(repository: string, root: Buffer, work: string,
8586/** Exclusive offline candidate only. This never changes installed firmware, boot slots or trust floors. */
8687export async function stageRuntimeFirmware(options: RuntimeFirmwarePolicy & { repository: string, trustedRoot: string, output: string }): Promise<RuntimeFirmwareStage> {
8788 const policy = admitPolicy(options)
88 const repository = realpathSync(options.repository), output = resolve(options.output)
89 const repository = realpathSync(options.repository), output = runtimeCandidateOutput(options.output, [repository])
8990 directory(repository)
9091 const root = regularFile(options.trustedRoot, metadataLimit)
9192 if (sha256(root) !== policy.trustedRootSha256) throw new Error('Trusted root SHA-256 does not match the independent pin')
92 // Resolve the existing parent before creating anything, so a symlinked parent cannot hide overlap.
93 const destination = join(realpathSync(dirname(output)), output.slice(dirname(output).length + 1))
94 const child = relative(repository, destination), parent = relative(destination, repository)
95 if (!child || (!child.startsWith(`..${sep}`) && child !== '..') || (!parent.startsWith(`..${sep}`) && parent !== '..')) throw new Error('Candidate and source repository must be separate')
9693 mkdirSync(output, { mode: 0o700 })
9794 writeExclusive(join(output, 'trust-root.json'), root)
9895 const { result, fetched, info } = await verifyRepository(repository, root, join(output, '.verification'), policy, join(output, 'image.bin'))
99 // Re-read the actual staged bytes, rather than trusting a successful copy or receipt.
100 await info.verify(Readable.from(regularFile(join(output, 'image.bin'), imageLimit)))
101 for (const [path, bytes] of fetched) {
102 const file = join(output, 'repository', path)
103 mkdirSync(dirname(file), { recursive: true, mode: 0o700 })
104 writeExclusive(file, bytes)
105 }
106 syncTree(output)
107 // A final marker means logical completeness. It cannot attest to power-loss durability after fsync.
108 writeExclusive(join(output, 'stage.json'), Buffer.from(`${JSON.stringify(result, null, 2)}\n`))
109 syncDirectory(output)
110 syncDirectory(dirname(output))
96 await finishRuntimeCandidate(output, info, result, fetched)
11197 return result
11298}
11399