ReviewOS

also looking at this

stacks/drone

feat: add scoped cargo receiving mission tasks

#102
Merged chris wants to merge codex/cargo-fleet-authority into main
21 files +1186 -15
tests/helpers/workspace-browser.tsmodified+17-5
Changes to tests/helpers/workspace-browser.ts
@@ -4,6 +4,8 @@ import { join } from 'node:path'
44import { observeBrowserOperation } from './browser-operation'
55import { browserFileErrorCode, retainBrowserLaunchEvidence } from './browser-launch-evidence'
66import type { BrowserLaunchObservation } from './browser-launch-evidence'
7import { createBrowserStartupObserver } from './browser-startup-process'
8import { createLinuxStartupObservation } from './browser-startup-linux'
79
810/** Dependency-free CDP, with a fresh profile. Credentials never enter command arguments. */
911async function openSocket(url: string): Promise<WebSocket> {
@@ -22,31 +24,41 @@ export async function startWorkspaceBrowser(root: string) {
2224 const child = Bun.spawn([process.env.BROWSE_BROWSER ?? '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', '--headless=new', '--disable-gpu', '--disable-background-timer-throttling', '--disable-renderer-backgrounding', '--disable-backgrounding-occluded-windows', '--disable-features=CalculateNativeWinOcclusion', '--disable-dev-shm-usage', '--disable-extensions', '--disable-component-update', '--no-first-run', '--no-default-browser-check', '--disable-background-networking', '--remote-debugging-port=0', `--user-data-dir=${profile}`, 'about:blank'], { stdout: 'ignore', stderr: Bun.file(join(root, 'chrome.log')) })
2325 const started = Date.now()
2426 const began = performance.now()
27 const startup = createBrowserStartupObserver(child.pid, began, process.platform === 'linux' ? createLinuxStartupObservation(child.pid, profile, began) : null)
2528 let closing = false
2629 const launch: BrowserLaunchObservation['launch'] = { pid: child.pid, exitObserved: false, settledExitCode: null, signalCode: null, exitObservedBeforeCleanup: false, cleanupRequested: false, exitElapsedMs: null }
2730 const portProbe: BrowserLaunchObservation['portProbe'] = { attempts: 0, successfulReads: 0, failedReads: 0, lastReadError: null, discovered: false }
2831 let pageVisited = false
29 const retain = (phase: BrowserLaunchObservation['phase']) => retainBrowserLaunchEvidence(root, { phase, elapsedMs: performance.now() - began, launch: { ...launch }, portProbe: { ...portProbe } }, { startupStderr: !pageVisited, exportDirectory: process.env.WORKSPACE_BROWSER_EVIDENCE ?? process.env.EXECUTION_BROWSER_EVIDENCE })
32 const retain = (phase: BrowserLaunchObservation['phase']) => retainBrowserLaunchEvidence(root, { phase, elapsedMs: performance.now() - began, launch: { ...launch }, portProbe: { ...portProbe }, startup: startup.evidence() }, { startupStderr: !pageVisited, exportDirectory: process.env.WORKSPACE_BROWSER_EVIDENCE ?? process.env.EXECUTION_BROWSER_EVIDENCE })
33 const cleanup = async () => {
34 closing = true; launch.cleanupRequested = true
35 if (child.exitCode === null) child.kill()
36 await Promise.race([child.exited, Bun.sleep(2000)])
37 if (!pageVisited) await startup.cleanupEnded()
38 }
3039 void child.exited.then(code => {
3140 launch.exitObserved = true; launch.settledExitCode = code; launch.signalCode = child.signalCode; launch.exitObservedBeforeCleanup = !closing; launch.exitElapsedMs = performance.now() - began
3241 if (!closing) console.log(`QA isolated Chrome exited unexpectedly: ${code}, elapsedMs:${Date.now() - started}`)
3342 })
3443 let port = ''
3544 for (let attempt = 0; attempt < 400; attempt++) {
45 startup.tick()
3646 portProbe.attempts++
3747 port = await readFile(join(profile, 'DevToolsActivePort'), 'utf8').then(value => { portProbe.successfulReads++; portProbe.lastReadError = null; return value.split('\n')[0]! }).catch(error => { portProbe.failedReads++; portProbe.lastReadError = browserFileErrorCode(error); return '' })
3848 if (port) { portProbe.discovered = true; break }
3949 await Bun.sleep(50)
4050 }
41 if (!port) { closing = true; launch.cleanupRequested = true; if (child.exitCode === null) child.kill(); await Promise.race([child.exited, Bun.sleep(2000)]); await retain('startup-unavailable'); throw new Error('Fresh browser must start') }
51 await startup.finishDiscovery()
52 if (!port) { await cleanup(); await retain('startup-unavailable'); throw new Error('Fresh browser must start') }
4253 // Keep a browser-level session, as well as page sessions, for the owned lifecycle.
4354 let browserSocket: WebSocket
4455 try {
4556 const response = await observeBrowserOperation('version-fetch', () => fetch(`http://127.0.0.1:${port}/json/version`, { signal: AbortSignal.timeout(5000) }))
46 const version = await observeBrowserOperation('version-json', () => response.json()) as { webSocketDebuggerUrl: string }
57 const version = await observeBrowserOperation('version-json', () => response.json()) as { webSocketDebuggerUrl: string, Browser?: unknown }
58 startup.recordVersion(version.Browser)
4759 browserSocket = await observeBrowserOperation('browser-socket', () => openSocket(version.webSocketDebuggerUrl))
4860 }
49 catch (error) { closing = true; launch.cleanupRequested = true; if (child.exitCode === null) child.kill(); await Promise.race([child.exited, Bun.sleep(2000)]); await retain('discovery-failed'); throw error }
61 catch (error) { await cleanup(); await retain('discovery-failed'); throw error }
5062 let browserSequence = 0
5163 browserSocket.onmessage = () => {}
5264 const keepAlive = setInterval(() => { if (browserSocket.readyState === WebSocket.OPEN) browserSocket.send(JSON.stringify({ id: ++browserSequence, method: 'Browser.getVersion' })) }, 5000)
@@ -96,6 +108,6 @@ export async function startWorkspaceBrowser(root: string) {
96108 await page.wait(javascript ? "document.querySelector('#incident-key') !== null && document.querySelector('[data-workspace-status]')?.textContent.trim() === 'disconnected'" : "document.querySelector('#incident-key') !== null", 'Compiled workspace must initialize')
97109 return page
98110 },
99 async close() { console.log(`QA browser.close requested, elapsedMs:${Date.now() - started}`); closing = true; launch.cleanupRequested = true; clearInterval(keepAlive); browserSocket.close(); for (const page of pages) page.close(); if (child.exitCode === null) child.kill(); await Promise.race([child.exited, Bun.sleep(2000)]); await retain('closed') },
111 async close() { console.log(`QA browser.close requested, elapsedMs:${Date.now() - started}`); clearInterval(keepAlive); browserSocket.close(); for (const page of pages) page.close(); await cleanup(); await retain('closed') },
100112 }
101113}