ReviewOS

also looking at this

stacks/commshq

refactor(ui): adopt shared workspace badges

#17
Merged glennmichael123 wants to merge refactor/commshq-shared-controls into main
5 files +118 -9
10 days ago

Summary

  • Replace five duplicated consent, metric-change, record-status, and readiness pills with the installed Stacks Badge component.
  • Preserve existing palettes, typography, padding, and inline/flex geometry using scoped Crosswind shortcuts.
  • Add rendering and generated-CSS regression coverage. No authentication, data, or notification behavior changes.

Validation

  • Targeted tests: 7 passed, 143 expectations.
  • Build: 55 pages succeeded; typecheck passed.
  • UI validation: 67 templates; scoped lint and diff checks passed.
  • Full-page compiled-UI QA: three pages at desktop/mobile sizes in light/dark themes (12 cases).
  • Before/after badge geometry and styles matched in all 12 cases; no horizontal overflow; minimum measured badge contrast 5.73:1.
  • Workspace loading, empty, error, and retry preview states checked.

Scope

One five-file commit. Browser checks used local compiled previews, not authenticated production or backend end-to-end tests. Auth-button migration is deferred to avoid changing pre-hydration label visibility. This PR is for review; no merge or deployment requested.

5 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.