ReviewOS

also looking at this

stacks/commshq

test(auth): pin the browser session contract, and gate the deploy

#14
Merged glennmichael123 wants to merge feat/auth-framework-session into main
4 files +400 -8

Review threads live on the whole diff, not on one commit, so none are shown here - a thread's line means something in the branch's final form, and painting it into an intermediate step would put it on code it is not about.

.github/workflows/deploy.ymlmodified+16-0
Changes to .github/workflows/deploy.yml
@@ -48,6 +48,22 @@ jobs:
4848 - name: Install dependencies
4949 run: bun install --frozen-lockfile
5050
51 # The suite runs here, not as a `needs:` on the CI workflow: `needs:`
52 # only reaches jobs in the same file, and lint/typecheck/test live in
53 # ci.yml. Without this, a push whose tests fail still deploys - as
54 # aac396460 did on 2026-09-24, where CI's test job failed and this
55 # workflow succeeded on the same sha, in the same minute. The whole
56 # suite costs a few seconds, so gating here is cheaper than a
57 # workflow_run indirection.
58 - name: Lint
59 run: ./buddy lint
60
61 - name: Typecheck
62 run: ./buddy typecheck
63
64 - name: Test
65 run: bun run test
66
5167 - name: Build the production artifact
5268 run: bun run build
5369