ReviewOS

also looking at this

stacks/bun-query-builder

fix(deps): apply the buddy rename contents, not just the file rename

#1174
Merged glennmichael123 wants to merge fix/buddy-rename-contents into main
4 files +20 -14
8 days ago

#1173 landed incomplete, and main is currently worse off than before it. This carries what that PR was supposed to.

What went wrong

#1173's squash commit fa140a2 is 1 file changed, 0 insertions(+), 0 deletions(-) — only the .config/buddy-bot.ts → .config/buddy.ts rename. None of the content changes were in it.

My git add listed the pre-rename path alongside the new one. That path no longer existed, git add failed on the unmatched pathspec and staged nothing further, and I had sent stderr to /dev/null. The git status --short output did show the files as unstaged — a leading space in the first column — and I read them as staged.

Why it matters

On main right now:

.config/buddy.tsrenamed, but still import type { BuddyBotConfig } from 'buddy-bot'
workflowstill 9 × bunx buddy-bot
@buddysh/buddy devDependencyabsent

So the workflow runs buddy-bot@0.10.5, which looks for .config/buddy-bot.ts — a file that no longer exists. The next scheduled run (cron: '0 */2 * * *', so within two hours) would execute with no config at all: no repository, no dashboard settings, no ignore lists. That is a regression the rename introduced, not a pre-existing state.

This PR

  • the nine bunx buddy-bot → bunx @buddysh/buddy invocations
  • the config's import and type, BuddyBotConfig → BuddyConfig
  • @buddysh/buddy ^0.11.2 as a devDependency, pinned in bun.lock
  • the branch check matching buddy/* as well as buddy-bot/*

Verification

This time I checked git status --porcelain showed M in the first column for all four files before committing, and the commit is 4 files changed, 20 insertions(+), 14 deletions(-).

  • getConfig() discovers .config/buddy.ts and returns stacksjs/bun-query-builder, not defaults
  • workflow YAML parses, all 5 jobs intact
  • bun install reports no changes, so the lockfile matches package.json
  • bun --bun tsc and pickier clean

Worth merging promptly given the two-hour cron.

🤖 Generated with Claude Code

4 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.