ReviewOS

also looking at this

stacks/bun-query-builder

chore(deps): update non-major dependencies, except kysely

#1157
Closed glennmichael123 wants to merge chore/deps-non-major into chore/remove-unused-imports
4 files +42 -238
8 days ago

Replaces #1139. Stacked on #1156 (the unused-import cleanup its pickier bump needs); this PR's own commit is the dependency sweep, and GitHub will retarget to main once #1156 lands.

Same bumps as the bot proposed, with two differences.

kysely is held back

kysely 0.28.14 → 0.29.6 breaks the benchmark's typecheck:

packages/benchmark/src/lib/db-clients.ts(221,5): error TS2769: No overload matches this call.
  Type 'BunSqliteDialect' is not assignable to type 'Dialect'.

kysely-bun-sqlite pins its own kysely 0.28 under node_modules/kysely-bun-sqlite/node_modules/kysely, so two copies end up in the tree and the dialect from one no longer satisfies the interface from the other. Nothing to fix on our side — it can move when kysely-bun-sqlite does.

Everything else in #1139 is here: @stacksjs/ts-validation 0.5.6 (the library's only runtime dependency), @stacksjs/bunpress 0.2.14, better-dx 0.2.25, pickier 0.1.65, ts-pantry 0.11.60, @stacksjs/clapp 0.2.16, dynamodb-tooling 0.3.6, bunfig 0.15.19, @types/bun 1.4.2, and the benchmark's @prisma/adapter-better-sqlite3 7.10.0 and typeorm 1.1.1.

Reproducing the bot's branch on top of main would also have reverted dev:docs/build:docs/preview:docs to vitepress, undoing #1148's fix — it was cut before that landed. Applying the bumps directly avoids that.

The docs config was never being read

bunpress 0.2.14 says so out loud:

[bunpress] docs/bunpress.config.ts is never loaded: config is discovered from the
working directory, not the docs directory.

It is not a new problem, just newly reported. Built without it, the site takes bunpress's defaults: <title>… | BunPress Documentation</title> and no sidebar. The three docs scripts now pass --config docs/bunpress.config.ts, which restores the title (… | bun-query-builder) and the nav/sidebar groups from that file (verified by diffing the built dist/.bunpress/guide/where/index.html).

Verification

With the new dependency tree installed: tsc clean at the root and in the package, pickier . 0 errors / 330 warnings (its baseline, and pickier@0.1.65 agrees once #1156's imports are gone), full suite 2246 pass / 0 fail / 10 skip, bun run build fine, and bun run build:docs builds all 41 pages.

bun.lock loses ~235 lines: the newer bunpress and ts-pantry drop a pile of transitive dependencies (@stacksjs/stx, ts-cloud, crosswind, archiver, …).

🤖 Generated with Claude Code

4 changed files on the files tab, with 0 review threads.

Sign in to comment on this pull request.