ReviewOS

also looking at this

stacks/bun-query-builder

fix(migrate)!: run the directories executeMigration was given

#1138
Merged glennmichael123 wants to merge fix/execute-migration-dirs into main
7 files +348 -49
packages/bun-query-builder/test/migrate-atomicity.test.tsmodified+3-3
Changes to packages/bun-query-builder/test/migrate-atomicity.test.ts
@@ -78,7 +78,7 @@ import { Database } from 'bun:sqlite'
7878import { setConfig, executeMigration } from ${JSON.stringify(SRC)}
7979
8080setConfig({ dialect: 'sqlite', database: { database: './t.sqlite' }, verbose: false })
81try { await executeMigration(process.cwd()) } catch {}
81try { await executeMigration() } catch {}
8282
8383const db = new Database('./t.sqlite')
8484// Explicit names, not a LIKE: 'mig_%' also matches the 'migrations' ledger.
@@ -121,7 +121,7 @@ import { setConfig, executeMigration } from ${JSON.stringify(SRC)}
121121
122122setConfig({ dialect: 'sqlite', database: { database: './t.sqlite' }, verbose: false })
123123let error = ''
124try { await executeMigration(process.cwd()) } catch (e) { error = e instanceof Error ? e.message : String(e) }
124try { await executeMigration() } catch (e) { error = e instanceof Error ? e.message : String(e) }
125125
126126const db = new Database('./t.sqlite')
127127const type = db.query("SELECT type FROM pragma_table_info('rebuilt') WHERE name = 'qty'").get()
@@ -165,7 +165,7 @@ describe.skipIf(!pgAvailable)('migration locking (#1067)', () => {
165165 writeFileSync(join(dir, 'worker.ts'), `
166166import { setConfig, executeMigration } from ${JSON.stringify(SRC)}
167167setConfig({ dialect: 'postgres', database: { url: ${JSON.stringify(PG_URL)} }, verbose: false })
168await executeMigration(process.cwd())
168await executeMigration()
169169`)
170170
171171 const result = run(dir, 'probe.ts', `